From ddc8fcf66fd04dd3685a7788d62c2a00ce2a27ee Mon Sep 17 00:00:00 2001 From: Kunht Kun Date: Sat, 12 Mar 2022 00:04:10 -0500 Subject: Avoid dereferencing null pointer Here `comm` could be a null pointer (the new test regress/2057 shows such a case). So test it before dereferencing to avoid segfault. Re: #2057 --- src/amount.cc | 3 ++- test/regress/2057.test | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 test/regress/2057.test diff --git a/src/amount.cc b/src/amount.cc index 0527c979..079ce777 100644 --- a/src/amount.cc +++ b/src/amount.cc @@ -732,7 +732,8 @@ void amount_t::in_place_unreduce() } if (shifted) { - if (("h" == comm->symbol() || "m" == comm->symbol()) && commodity_t::time_colon_by_default) { + if (comm && ("h" == comm->symbol() || "m" == comm->symbol()) + && commodity_t::time_colon_by_default) { double truncated = trunc(tmp.to_double()); double precision = tmp.to_double() - truncated; tmp = truncated + (precision * (comm->smaller()->number() / 100.0)); diff --git a/test/regress/2057.test b/test/regress/2057.test new file mode 100644 index 00000000..f691b350 --- /dev/null +++ b/test/regress/2057.test @@ -0,0 +1,12 @@ +C 1 "" = 1 $ + +2021-01-01 Test + A $10 + B + +test bal + 10 A + -10 B +-------------------- + 0 +end test -- cgit v1.2.3