From c43098d5bd91b6af733cb19225ebaf29228c2c50 Mon Sep 17 00:00:00 2001 From: David Sklar <177495+davidsklar@users.noreply.github.com> Date: Thu, 29 Dec 2022 13:37:27 -0500 Subject: Python: test cleanups 1. Remove references to modules (exceptions, StringIO) no longer needed for Pythn3 2. Use assertEqual instead of assertEquals 3. Clear journal files with a close_journal_files() function that uses the then-current underlying python_session pointer. Calling session.close_journal_files() sometimes leads to segfaults because python_session has changed after it was injected into the python module (as "session") on module startup. --- src/py_session.cc | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/py_session.cc') diff --git a/src/py_session.cc b/src/py_session.cc index b948997c..167eb2a4 100644 --- a/src/py_session.cc +++ b/src/py_session.cc @@ -55,6 +55,9 @@ namespace { { return str_to_py_unicode(error_context()); } + void py_close_journal_files() { + python_session->close_journal_files(); + } } void export_session() @@ -74,6 +77,8 @@ void export_session() scope().attr("session") = object(ptr(static_cast(python_session.get()))); + scope().attr("close_journal_files") = + python::make_function(&py_close_journal_files); scope().attr("read_journal") = python::make_function(&py_read_journal, return_internal_reference<>()); -- cgit v1.2.3