diff options
author | Thomas Lively <7121787+tlively@users.noreply.github.com> | 2019-12-11 17:12:37 -0800 |
---|---|---|
committer | Alon Zakai <azakai@google.com> | 2019-12-11 17:12:37 -0800 |
commit | 759c485a9f35bd859d43b86b02e1397a669fa469 (patch) | |
tree | a5c7475002b406e35c6d1e5c2d843000947ef192 /src/abi/stack.h | |
parent | acd786dbd1e59f9d105c4ec8603c2ff46f233649 (diff) | |
download | binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.tar.gz binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.tar.bz2 binaryen-759c485a9f35bd859d43b86b02e1397a669fa469.zip |
Remove FunctionType (#2510)
Function signatures were previously redundantly stored on Function
objects as well as on FunctionType objects. These two signature
representations had to always be kept in sync, which was error-prone
and needlessly complex. This PR takes advantage of the new ability of
Type to represent multiple value types by consolidating function
signatures as a pair of Types (params and results) stored on the
Function object.
Since there are no longer module-global named function types,
significant changes had to be made to the printing and emitting of
function types, as well as their parsing and manipulation in various
passes.
The C and JS APIs and their tests also had to be updated to remove
named function types.
Diffstat (limited to 'src/abi/stack.h')
-rw-r--r-- | src/abi/stack.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/abi/stack.h b/src/abi/stack.h index 68ac7f08a..265a7af6e 100644 --- a/src/abi/stack.h +++ b/src/abi/stack.h @@ -128,10 +128,10 @@ getStackSpace(Index local, Function* func, Index size, Module& wasm) { // no need to restore the old stack value, we're gone anyhow } else { // save the return value - auto temp = builder.addVar(func, func->result); + auto temp = builder.addVar(func, func->sig.results); block->list.push_back(builder.makeLocalSet(temp, func->body)); block->list.push_back(makeStackRestore()); - block->list.push_back(builder.makeLocalGet(temp, func->result)); + block->list.push_back(builder.makeLocalGet(temp, func->sig.results)); } block->finalize(); func->body = block; |