Validate finalization (#1014)

* validate that types are properly finalized, when in pass-debug mode (BINARYEN_PASS_DEBUG env var): check after each pass is run that the type of each node is equal to the proper type (when finalizing it, i.e., fully recomputing the type).

* fix many fuzz bugs found by that.

* in particular, fix dce bugs with type changes not being fully updated during code removal. add a new TypeUpdater helper class that lets a pass update types efficiently, by the helper tracking deps between blocks and branches etc., and updating/propagating type changes only as necessary.

1 files changed, 7 insertions, 0 deletions

diff --git a/src/passes/RelooperJumpThreading.cpp b/src/passes/RelooperJumpThreading.cpp
index d3fd1844f..3656b5523 100644
--- a/src/passes/RelooperJumpThreading.cpp
+++ b/src/passes/RelooperJumpThreading.cpp
@@ -22,9 +22,11 @@
 #include "wasm.h"
 #include "pass.h"
 #include "ast_utils.h"
+#include "ast/manipulation.h"
 
 namespace wasm {
 
+
 static Name LABEL("label");
 
 static Name getInnerName(int i) {
@@ -147,6 +149,11 @@ struct RelooperJumpThreading : public WalkerPass<ExpressionStackWalker<RelooperJ
     }
   }
 
+  void visitFunction(Function* curr) {
+    // we may alter types
+    ReFinalize().walkFunctionInModule(curr, getModule());
+  }
+
 private:
 
   bool hasIrreducibleControlFlow(If* iff, Expression* origin) {