summaryrefslogtreecommitdiff
path: root/src/passes
diff options
context:
space:
mode:
Diffstat (limited to 'src/passes')
-rw-r--r--src/passes/RemoveUnusedBrs.cpp7
-rw-r--r--src/passes/pass.cpp2
2 files changed, 9 insertions, 0 deletions
diff --git a/src/passes/RemoveUnusedBrs.cpp b/src/passes/RemoveUnusedBrs.cpp
index ffdba0768..3f909c32e 100644
--- a/src/passes/RemoveUnusedBrs.cpp
+++ b/src/passes/RemoveUnusedBrs.cpp
@@ -128,6 +128,13 @@ struct RemoveUnusedBrs : public WalkerPass<PostWalker<RemoveUnusedBrs, Visitor<R
// if without an else. try to reduce if (condition) br => br_if (condition)
Break* br = curr->ifTrue->dynCast<Break>();
if (br && !br->condition) { // TODO: if there is a condition, join them
+ // if the br has a value, then if => br_if means we always execute the value, and also the order is value,condition vs condition,value
+ if (br->value) {
+ EffectAnalyzer value(br->value);
+ if (value.hasSideEffects()) return;
+ EffectAnalyzer condition(curr->condition);
+ if (condition.invalidates(value)) return;
+ }
br->condition = curr->condition;
replaceCurrent(br);
anotherCycle = true;
diff --git a/src/passes/pass.cpp b/src/passes/pass.cpp
index e43b712e5..babb4635b 100644
--- a/src/passes/pass.cpp
+++ b/src/passes/pass.cpp
@@ -65,6 +65,7 @@ void PassRunner::addDefaultOptimizationPasses() {
add("optimize-instructions");
add("simplify-locals");
add("vacuum"); // previous pass creates garbage
+ add("remove-unused-brs"); // simplify-locals opens opportunities for phi optimizations
add("coalesce-locals");
add("vacuum"); // previous pass creates garbage
add("reorder-locals");
@@ -81,6 +82,7 @@ void PassRunner::addDefaultFunctionOptimizationPasses() {
add("optimize-instructions");
add("simplify-locals");
add("vacuum"); // previous pass creates garbage
+ add("remove-unused-brs"); // simplify-locals opens opportunities for phi optimizations
add("coalesce-locals");
add("vacuum"); // previous pass creates garbage
add("reorder-locals");