diff options
Diffstat (limited to 'src/wasm')
-rw-r--r-- | src/wasm/wasm-type.cpp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/wasm/wasm-type.cpp b/src/wasm/wasm-type.cpp index d06bfcbe7..64fd07759 100644 --- a/src/wasm/wasm-type.cpp +++ b/src/wasm/wasm-type.cpp @@ -1728,10 +1728,7 @@ bool SubTyper::isSubType(const Field& a, const Field& b) { } bool SubTyper::isSubType(const Signature& a, const Signature& b) { - // TODO: Implement proper signature subtyping, covariant in results and - // contravariant in params, once V8 implements it. - // return isSubType(b.params, a.params) && isSubType(a.results, b.results); - return a == b; + return isSubType(b.params, a.params) && isSubType(a.results, b.results); } bool SubTyper::isSubType(const Struct& a, const Struct& b) { @@ -2906,11 +2903,6 @@ TypeBuilder::BuildResult TypeBuilder::build() { state.newInfos.emplace_back(std::move(info)); } -#if TRACE_CANONICALIZATION - std::cerr << "Before replacing basic heap types:\n"; - state.dump(); -#endif - // Eagerly replace references to built basic heap types so the more // complicated canonicalization algorithms don't need to consider them. canonicalizeBasicTypes(state); |