diff options
Diffstat (limited to 'src')
-rw-r--r-- | src/js/wasm.js-post.js | 2 | ||||
-rw-r--r-- | src/passes/SimplifyLocals.cpp | 17 | ||||
-rw-r--r-- | src/support/archive.cpp | 4 | ||||
-rw-r--r-- | src/wasm-linker.cpp | 38 | ||||
-rw-r--r-- | src/wasm.h | 34 |
5 files changed, 67 insertions, 28 deletions
diff --git a/src/js/wasm.js-post.js b/src/js/wasm.js-post.js index a0c026c91..6d73981f1 100644 --- a/src/js/wasm.js-post.js +++ b/src/js/wasm.js-post.js @@ -188,7 +188,7 @@ function integrateWasmJS(Module) { info['env'] = env; var instance; try { - instance = Wasm.instantiateModule(getBinary(), info); + instance = Wasm['instantiateModule'](getBinary(), info); } catch (e) { Module['printErr']('failed to compile wasm module: ' + e); return false; diff --git a/src/passes/SimplifyLocals.cpp b/src/passes/SimplifyLocals.cpp index 785bccf06..fbd1e7e57 100644 --- a/src/passes/SimplifyLocals.cpp +++ b/src/passes/SimplifyLocals.cpp @@ -126,6 +126,7 @@ struct SimplifyLocals : public WalkerPass<LinearExecutionWalker<SimplifyLocals, for (auto target : sw->targets) { self->unoptimizableBlocks.insert(target); } + self->unoptimizableBlocks.insert(sw->default_); // TODO: we could use this info to stop gathering data on these blocks } self->sinkables.clear(); @@ -161,12 +162,16 @@ struct SimplifyLocals : public WalkerPass<LinearExecutionWalker<SimplifyLocals, // post-block cleanups if (curr->name.is()) { - unoptimizableBlocks.erase(curr->name); - } - if (hasBreaks) { - // more than one path to here, so nonlinear - sinkables.clear(); - blockBreaks.erase(curr->name); + if (unoptimizableBlocks.count(curr->name)) { + sinkables.clear(); + unoptimizableBlocks.erase(curr->name); + } + + if (hasBreaks) { + // more than one path to here, so nonlinear + sinkables.clear(); + blockBreaks.erase(curr->name); + } } } diff --git a/src/support/archive.cpp b/src/support/archive.cpp index c0351bc05..126f4e2ce 100644 --- a/src/support/archive.cpp +++ b/src/support/archive.cpp @@ -210,8 +210,8 @@ static uint32_t read32be(const uint8_t* buf) { } void Archive::dump() const { - printf("Archive data %p len %lu, firstRegularData %p\n", data.data(), - (long unsigned)data.size(), firstRegularData); + printf("Archive data %p len %zu, firstRegularData %p\n", data.data(), + data.size(), firstRegularData); printf("Symbol table %p, len %u\n", symbolTable.data, symbolTable.len); printf("string table %p, len %u\n", stringTable.data, stringTable.len); const uint8_t* buf = symbolTable.data; diff --git a/src/wasm-linker.cpp b/src/wasm-linker.cpp index f4f516073..a4bd97e2f 100644 --- a/src/wasm-linker.cpp +++ b/src/wasm-linker.cpp @@ -217,23 +217,31 @@ bool Linker::linkObject(S2WasmBuilder& builder) { } bool Linker::linkArchive(Archive& archive) { - for (auto child = archive.child_begin(), end = archive.child_end(); - child != end; ++child) { - Archive::SubBuffer memberBuf = child->getBuffer(); - // S2WasmBuilder expects its input to be NUL-terminated. Archive members are - // not NUL-terminated. So we have to copy the contents out before parsing. - std::vector<char> memberString(memberBuf.len + 1); - memcpy(memberString.data(), memberBuf.data, memberBuf.len); - memberString[memberBuf.len] = '\0'; - S2WasmBuilder memberBuilder(memberString.data(), false); - auto* memberSymbols = memberBuilder.getSymbolInfo(); - for (const Name& symbol : memberSymbols->implementedFunctions) { - if (out.symbolInfo.undefinedFunctions.count(symbol)) { - if (!linkObject(memberBuilder)) return false; - break; + bool selected; + do { + selected = false; + for (auto child = archive.child_begin(), end = archive.child_end(); + child != end; ++child) { + Archive::SubBuffer memberBuf = child->getBuffer(); + // S2WasmBuilder expects its input to be NUL-terminated. Archive members + // are + // not NUL-terminated. So we have to copy the contents out before parsing. + std::vector<char> memberString(memberBuf.len + 1); + memcpy(memberString.data(), memberBuf.data, memberBuf.len); + memberString[memberBuf.len] = '\0'; + S2WasmBuilder memberBuilder(memberString.data(), false); + auto* memberSymbols = memberBuilder.getSymbolInfo(); + for (const Name& symbol : memberSymbols->implementedFunctions) { + if (out.symbolInfo.undefinedFunctions.count(symbol)) { + if (!linkObject(memberBuilder)) return false; + selected = true; + break; + } } } - } + // If we selected an archive member, it may depend on another archive member + // so continue to make passes over the members until no more are added. + } while (selected); return true; } diff --git a/src/wasm.h b/src/wasm.h index f7ed6b42f..dff0bcd5a 100644 --- a/src/wasm.h +++ b/src/wasm.h @@ -246,11 +246,37 @@ private: } } + static uint32_t NaNPayload(float f) { + assert(std::isnan(f) && "expected a NaN"); + // SEEEEEEE EFFFFFFF FFFFFFFF FFFFFFFF + // NaN has all-one exponent and non-zero fraction. + return ~0xff800000u & bit_cast<uint32_t>(f); + } + + static uint64_t NaNPayload(double f) { + assert(std::isnan(f) && "expected a NaN"); + // SEEEEEEE EEEEFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF + // NaN has all-one exponent and non-zero fraction. + return ~0xfff0000000000000ull & bit_cast<uint64_t>(f); + } + + static float setQuietNaN(float f) { + assert(std::isnan(f) && "expected a NaN"); + // An SNaN is a NaN with the most significant fraction bit clear. + return bit_cast<float>(0x00400000u | bit_cast<uint32_t>(f)); + } + + static double setQuietNaN(double f) { + assert(std::isnan(f) && "expected a NaN"); + // An SNaN is a NaN with the most significant fraction bit clear. + return bit_cast<double>(0x0008000000000000ull | bit_cast<uint64_t>(f)); + } + static void printFloat(std::ostream &o, float f) { if (std::isnan(f)) { const char *sign = std::signbit(f) ? "-" : ""; o << sign << "nan"; - if (uint32_t payload = ~0xff800000u & bit_cast<uint32_t>(f)) { + if (uint32_t payload = NaNPayload(f)) { o << ":0x" << std::hex << payload << std::dec; } return; @@ -266,7 +292,7 @@ private: if (std::isnan(d)) { const char *sign = std::signbit(d) ? "-" : ""; o << sign << "nan"; - if (uint64_t payload = ~0xfff0000000000000ull & bit_cast<uint64_t>(d)) { + if (uint64_t payload = NaNPayload(d)) { o << ":0x" << std::hex << payload << std::dec; } return; @@ -448,7 +474,7 @@ private: switch (std::fpclassify(rhs)) { case FP_ZERO: switch (std::fpclassify(lhs)) { - case FP_NAN: return *this; + case FP_NAN: return Literal(setQuietNaN(lhs)); case FP_ZERO: return Literal(std::copysign(std::numeric_limits<float>::quiet_NaN(), sign)); case FP_NORMAL: // fallthrough case FP_SUBNORMAL: // fallthrough @@ -468,7 +494,7 @@ private: switch (std::fpclassify(rhs)) { case FP_ZERO: switch (std::fpclassify(lhs)) { - case FP_NAN: return *this; + case FP_NAN: return Literal(setQuietNaN(lhs)); case FP_ZERO: return Literal(std::copysign(std::numeric_limits<double>::quiet_NaN(), sign)); case FP_NORMAL: // fallthrough case FP_SUBNORMAL: // fallthrough |