summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/passes/Vacuum.cpp49
1 files changed, 1 insertions, 48 deletions
diff --git a/src/passes/Vacuum.cpp b/src/passes/Vacuum.cpp
index 7c394900d..8d89553b2 100644
--- a/src/passes/Vacuum.cpp
+++ b/src/passes/Vacuum.cpp
@@ -23,7 +23,6 @@
#include <ir/effects.h>
#include <ir/iteration.h>
#include <ir/literal-utils.h>
-#include <ir/type-updating.h>
#include <ir/utils.h>
#include <pass.h>
#include <wasm-builder.h>
@@ -36,32 +35,9 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
std::unique_ptr<Pass> create() override { return std::make_unique<Vacuum>(); }
- TypeUpdater typeUpdater;
-
- // The TypeUpdater class handles efficient updating of unreachability as we
- // go, but we may also refine types, which requires refinalization.
- bool refinalize = false;
-
- Expression* replaceCurrent(Expression* expression) {
- auto* old = getCurrent();
- if (expression->type != old->type &&
- expression->type != Type::unreachable) {
- // We are changing this to a new type that is not unreachable, so it is a
- // refinement that we need to use refinalize to propagate up.
- refinalize = true;
- }
- super::replaceCurrent(expression);
- // also update the type updater
- typeUpdater.noteReplacement(old, expression);
- return expression;
- }
-
void doWalkFunction(Function* func) {
- typeUpdater.walk(func->body);
walk(func->body);
- if (refinalize) {
- ReFinalize().walkFunctionInModule(func, getModule());
- }
+ ReFinalize().walkFunctionInModule(func, getModule());
}
// Returns nullptr if curr is dead, curr if it must stay as is, or one of its
@@ -185,11 +161,9 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
}
}
if (!optimized) {
- typeUpdater.noteRecursiveRemoval(child);
skip++;
} else {
if (optimized != child) {
- typeUpdater.noteReplacement(child, optimized);
list[z] = optimized;
}
if (skip > 0) {
@@ -198,14 +172,7 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
}
// if this is unreachable, the rest is dead code
if (list[z - skip]->type == Type::unreachable && z < size - 1) {
- for (Index i = z - skip + 1; i < list.size(); i++) {
- auto* remove = list[i];
- if (remove) {
- typeUpdater.noteRecursiveRemoval(remove);
- }
- }
list.resize(z - skip + 1);
- typeUpdater.maybeUpdateTypeToUnreachable(curr);
skip = 0; // nothing more to do on the list
break;
}
@@ -213,7 +180,6 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
}
if (skip > 0) {
list.resize(size - skip);
- typeUpdater.maybeUpdateTypeToUnreachable(curr);
}
// the block may now be a trivial one that we can get rid of and just leave
// its contents
@@ -227,15 +193,10 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
Expression* child;
if (value->value.getInteger()) {
child = curr->ifTrue;
- if (curr->ifFalse) {
- typeUpdater.noteRecursiveRemoval(curr->ifFalse);
- }
} else {
if (curr->ifFalse) {
child = curr->ifFalse;
- typeUpdater.noteRecursiveRemoval(curr->ifTrue);
} else {
- typeUpdater.noteRecursiveRemoval(curr);
ExpressionManipulator::nop(curr);
return;
}
@@ -245,10 +206,6 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
}
// if the condition is unreachable, just return it
if (curr->condition->type == Type::unreachable) {
- typeUpdater.noteRecursiveRemoval(curr->ifTrue);
- if (curr->ifFalse) {
- typeUpdater.noteRecursiveRemoval(curr->ifFalse);
- }
replaceCurrent(curr->condition);
return;
}
@@ -384,9 +341,6 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
// the try's body.
if (!EffectAnalyzer(getPassOptions(), *getModule(), curr->body).throws()) {
replaceCurrent(curr->body);
- for (auto* catchBody : curr->catchBodies) {
- typeUpdater.noteRecursiveRemoval(catchBody);
- }
return;
}
@@ -398,7 +352,6 @@ struct Vacuum : public WalkerPass<ExpressionStackWalker<Vacuum>> {
if (curr->type == Type::none && curr->hasCatchAll() &&
!EffectAnalyzer(getPassOptions(), *getModule(), curr)
.hasUnremovableSideEffects()) {
- typeUpdater.noteRecursiveRemoval(curr);
ExpressionManipulator::nop(curr);
}
}