summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix issues with ref.cast_nop (#5473)Alon Zakai2023-02-033-3/+3
| | | | It did not have proper annotation for the safety field, and also it could not handle basic heap types.
* Optimize ref.as_non_null removal effect computation (#5479)Alon Zakai2023-02-031-8/+14
| | | Followup to #5474
* [Wasm GC] Fix struct.set / ref.as_non_null ordering issue (#5474)Alon Zakai2023-02-021-10/+51
| | | | | | | | | | | If traps can happen, then we can't always remove a trap on null on the ref input to struct.set, since it has two children, (struct.set (ref.as_non_null X) (call $foo)) Removing the ref.as would not prevent a trap, as the struct.set will trap, but it does move the trap to after the call which is bad.
* [Wasm GC] Fix RemoveUnusedModuleEffects struct field reads with ↵Alon Zakai2023-02-021-5/+31
| | | | | | | | | | | | | | | | | | call.without.effects (#5477) If we see (struct.new $A (call $call.without.effects ;; intrinsic (ref.func $getter) ) ) then we can ignore side effects in that call, as the intrinsic tells us to. However, that function is still called (it will be called normally, after intrinsics are lowered away), and we should not remove it. That is, such an intrinsic call can be removed, but it cannot be left as it is and also ignored as if it does not exist.
* Fix racing merge breakage (#5472)Alon Zakai2023-02-011-3/+1
|
* [C API] Add experimental StringNew and StringEq variants (#5471)dcode2023-02-013-7/+45
| | | | Adds APIs for string.from_code_point, string.new_utf8_try, string.new_utf8_array_try (#5459) and string.compare (#5453).
* RemoveUnusedModuleElements: Support function subtyping (#5470)Alon Zakai2023-02-011-18/+32
| | | | When we see a call_ref or call_indirect of a heap type, we might be calling a subtype of that type.
* RemoveUnusedModuleElements: Optimize unread struct.new fields (#5445)Alon Zakai2023-02-012-3/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is similar to the existing optimization for function references: a RefFunc is just a reference, and we do not consider the function actually used unless some CallRef can actually call it. Here we optimize StructNew fields by tracking if they are read. Consider this object: (struct.new $object (global.get $vtable) ) Before this PR, when we saw that StructNew we'd make that global used, and process all of its contents, which look like this: (global $vtable (struct.new $object (ref.func $foo) ) ) With this PR we track which fields on the struct types are even read. If they are not then we do not add uses of the things they refer to. In this example, the global vtable would be referenced, but not used, and likewise the RefFunc inside it. The technical way we handle this is to walk StructNews carefully: when we see a field that has been read, we can just read it normally, but if it has not been read then we note it on the side, and only process it later if we see a read.
* RemoveUnusedModuleElements: Handle changes to tables (#5469)Alon Zakai2023-01-311-0/+5
| | | | | This is a long-standing bug - we ignored the possibility of table.set in this pass. We have few tests for this so it took a while for the fuzzer to notice it I suppose.
* OptimizeInstructions: Handle signed overflow properly in canOverflow() (#5467)Alon Zakai2023-01-311-13/+23
| | | | | We only checked for an unsigned overflow, which was wrong. Fixes #5464
* [NFC] Refactor RemoveUsedModuleElements to clarify references and uses (#5444)Alon Zakai2023-01-311-196/+309
| | | | | | | | | | | | | | | | | | | This pass talked about reachability and uses and such, but it wasn't very clear on those things. This refactors it to clarify that we look for references and uses, and what that means. Specifically, a reference to something makes us keep it alive, as we need to refer to it; a use makes us also keep it identical in its contents so that when it is used no behavior changes. A function reference without a call_ref that can call it is an example of a reference without a use, which this pass already optimized. To make that more clear in the code, this refactors out the reference-finding logic into a new struct, ReferenceFinder. This also replaces the normal walking logic with a more manual traversal using ChildIterator. This is necessary to properly differentiate references from uses, but is not immediately useful in this PR except for clarity. It will be necessary in the next PR, which this prepares for, in which we'll optimize more reference-but-not-use things.
* [NFC] Improve debug printing for type canonicalization (#5465)Thomas Lively2023-01-301-2/+3
| | | | | | Use an `IndexedTypeNameGenerator` to give types stable names for the entire `dump` method rather than generating fresh type names every time a single type is printed. This makes it possible to understand the relationships between the types in the debug output.
* [Wasm GC] Refinalize fuzz fix in OptimizeInstructions cast optimizations (#5460)Alon Zakai2023-01-261-0/+6
|
* [Strings] Add experimental StringNew variants (#5459)Alon Zakai2023-01-2613-80/+194
| | | | | | string.from_code_point makes a string from an int code point. string.new_utf8*_try makes a utf8 string and returns null on a UTF8 encoding error rather than trap.
* Add explicit include for <cstdint> (#5458)rathann2023-01-261-0/+1
| | | | | | This fixes the following error when compiling with GCC 13: "'uint64_t' does not name a type"
* [Strings] Add string.compare (#5453)Alon Zakai2023-01-2512-30/+87
| | | See WebAssembly/stringref#58
* Merge more sibling types in TypeMerging (#5452)Thomas Lively2023-01-251-14/+21
| | | | | | | | | | | | | TypeMerging was previously able to merge identical root types and identical siblings that were children of a distinct type, but only when the siblings had the same top-level structure as their parent. Improve the optimization by also merging identical children when they have a different top-level structure from their parent. This solution is not fully general because it does not merge shape-refining children of separate types that would become identical siblings only after their parent types are merged, but that full generality would require either modifying Valmari-Lehtinen DFA minimization or performing the DFA minimization in a loop until reaching a fixpoint.
* Avoid spurious warnings in pass skipping (#5451)Alon Zakai2023-01-251-7/+11
| | | | | Nested runners should be ignored, as they run some internal stuff in certain passes, which would not contain the pass the user asked to skip with --skip-pass.
* Fix a typo in Flat IR validation logic (#5450)Alon Zakai2023-01-251-1/+1
| | | `doVisitFunction` does not exist.
* Add a mechanism to skip a pass by name (#5448)Alon Zakai2023-01-243-0/+38
| | | | | | | | For example, -O3 --skip-pass=vacuum will run -O3 normally but it will not run the vacuum pass at all (which normally runs more than once in -O3).
* Fix OptimizeInstructions on null trap of struct.set (#5449)Alon Zakai2023-01-241-3/+7
| | | StructSet cannot be dropped.
* Support using JSPI to load the secondary wasm split module. (#5431)Brendan Dahl2023-01-207-25/+119
| | | | | | | | | | When using JSPI with wasm-split, any calls to secondary module functions will now first check a global to see if the module is loaded. If not loaded it will call a JSPI'ed function that will handle loading module. The setup is split into the JSPI pass and wasm-split tool since the JSPI pass is first run by emscripten and we need to JSPI'ify the load secondary module function. wasm-split then injects all the checks and calls to the load function.
* Fix segment fault in API BinaryenModuleParse (#5440) (#5441)Changqing Jing2023-01-203-14/+16
| | | | | | We cannot modify the input string safely. To avoid that, copy where needed. Fixes #5440
* [Wasm GC] Fix supertype ordering bug in GlobalTypeRewriter (#5442)Thomas Lively2023-01-193-5/+46
| | | | | | | | | | | | | GlobalTypeRewriter made sure to order supertypes before their subtypes so that type building would succeed, but this ordering previously did not account for the fact that supertypes might be replaced by the type updating. When a supertype is replaced, the replacement might not previously have had a supertype/subtype relationship with the subtype, so it might have happened to be ordered after the subtype. Fix the problem by taking supertype replacements into account when ordering types in the GlobalTypeRewriter. This requires generalizing the `SupertypesFirst` utility in wasm-type-ordering.h to allow users to modify how supertypes are found.
* [Wasm GC] Do not merge supertypes into subtypes (#5439)Thomas Lively2023-01-191-3/+8
| | | | | | | | | | In TypeMerging we previously merged all subsequent types in a refined partition into whichever type happened to be first in the partition, but when that first type happened to be a subtype of one of the other types in the partition, that would cause type-updating.cpp to try to update that subtype's supertype to be itself, causing an assertion failure. Fix the problem by ensuring that the merge target is not a subtype of any other types in the partition.
* [Wasm GC] Merge root types with identical shapes (#5438)Thomas Lively2023-01-191-50/+161
| | | | | | | | | | The TypeMerging optimization usually tries to merge types into their supertypes, but it can also merge sibling types together without merging them into their common supertype. Implement this kind of sibling merging for root types that have no nontrivial supertypes. Root types were previously never merged. The implementation requires hashing and comparing the top-level structure of the root types so that root types with the same structure can be assigned to the same partition for DFA minimization.
* [Wasm GC] Use DFA minimization to merge types (#5432)Thomas Lively2023-01-183-148/+329
| | | | | | | | | | | | | | | | | | | | | Analyze type merging candidates as states in a DFA, using a partition refining DFA minimization algorithm to more aggressively find sets of mergeable types. The new implementation can merge types that the previous iteration would have taken an arbitrary number of iterations to merge or would not have been able to merge at all. The new implementation is also careful in its treatment of private and public types and should work as-is under an open world assumption or a relaxed closed-world assumption that admits more public types. Specifically, the new code avoids merging public types into their supertypes, but still allows private subtypes to be merged into their public supertypes. The new implementation supports merging function types, which the old implementation did not. Finally, the new implementation is able to merge identical sibling types even when the analysis determines that they cannot be merged into their common supertype. Extending this capability to sibling top-level types without nontrivial supertypes is left to a follow-on PR.
* Add a TypeNameGenerator that uses names from a Module (#5437)Thomas Lively2023-01-182-1/+33
| | | | | | | | | If the module does not have a name for a particular type, the new utility falls back to use a different user-configurable type name generator, just like the existing IndexedTypeNameGenerator does. Also change how heap types are printed by this printing machinery (which is currently only used for debugging) so that their names are printed in addition to their contents. This makes the printer much more useful for debugging.
* Factor supertype-first type sort into separate header (#5436)Thomas Lively2023-01-182-25/+70
| | | | | | | | | | | | | | | type-updating.cpp implemented a topological sorts on heap types that would visit supertypes first. Since this same sort will be used by TypeMerging.cpp in #5432, factor it out into a shared utility in a new wasm-type-ordering.h header. At the same time, fix a bug in which the sort would visit types not in the input collection. Concretely, this bug would cause public supertypes of private types to be visited when only private types should have been visited. This functionality change will be tested in #5432. In principle the subtype-first sort used in subtypes.h could also be moved to this header, but that is not yet duplicated in the code base and is more efficient because it depends on implementation details of its current context, so do not move it for now.
* Add Valmari-Lehtinen DFA minimization as a standalone utility (#5430)Thomas Lively2023-01-173-0/+466
| | | | | | | | We used to have this algorithm in wasm-type.cpp, where we used it to implement equirecursive type canonicalization, but we removed it when we removed equirecursive typing. Bring the algorithm back as a standalone utility for future use in optimization passes. In particular, it will be useful in TypeMerging for identifying the greatest fixed point of mergeable types rather than the smallest fixed point.
* [NFC] Work a little more efficiently in RemoveUnusedModuleElements (#5429)Alon Zakai2023-01-131-22/+33
| | | | | | Before, we'd potentially add a new item to the queue multiple times, then do nothing when popping it from the queue in the second and later times. With this PR we add a new item to the reachable set and to the queue at the same time, so items cannot appear more than once in the queue.
* [Wasm GC] SignaturePruning should not prune fields from a type with subtypes ↵Alon Zakai2023-01-131-3/+11
| | | | | | (#5427) For subtyping to not break, we must leave the number of fields equal in both super and subtype, for each such pair.
* Move closed world flag to tool options (#5428)Alon Zakai2023-01-132-13/+13
| | | | This allows tools like wasm-reduce to be told to operate in closed-world mode. That lets them validate in the more strict way of that mode.
* [Wasm GC] Optimize successful casts better (#5426)Thomas Lively2023-01-132-26/+56
| | | | | | Optimize ref.cast instructions that must succeed by simply replacing them with their child in the case where the child has a more refined type or by propagating a further removed fallthrough value with a more refined type using a tee.
* [Wasm GC] Allow TypeMerging to merge cast types with TNH (#5425)Thomas Lively2023-01-121-4/+19
| | | | | | If traps are assumed never to happen, then ref.cast and call_indirect instructions cannot differentiate between types because they always succeed. Take advantage of this fact by only having these instructions inhibit type merges when we are not assuming traps never happen.
* [Wasm GC] Support and fuzz function subtyping (#5420)Thomas Lively2023-01-123-53/+196
| | | | | | | | | | Support function subtyping with contravariant parameters and covariant results. The actual change is a single line in wasm-type.cpp, so most of the patch is updating the type fuzzer to generate interesting function subtypes. Since function parameters are covariant, generating a function subtype requires generating supertypes of its parameter types, which required new functionality in the fuzzer. Also update the fuzzer to choose to reuse types at a finer grain, so for example individual function parameters or results might be reused unmodified while other parameters or results are still modified.
* [Wasm GC] Optimize casts of null values better (#5423)Thomas Lively2023-01-122-37/+29
| | | | | | | | | Instead of only looking at the final fallthrough value and seeing whether it is a `RefNull` expression to determine if we are casting a null value, check the type of each intermediate fallthrough value to see if it is a null reference. Also improve `evaluateCastCheck` to return `Failure` instead of `SuccessOnlyIfNonNull` if the cast value is a reference to bottom type, since those can never be non-null.
* [Wasm GC] Fix cast finding in TypeMerging (#5424)Thomas Lively2023-01-121-27/+14
| | | | | | | | | | The cast finding code in TypeMerging has been broken since we refactored how casts work to support nullable casts. The cast finding code only considered HeapType fields and the return type of `RefCast` to be potential cast targets, but `RefTest` and `BrOn` instructions now store their cast types as `Type` fields. Since cast targets are represented more heterogenously now, do not use the delegations macros to find them. Add tests showing that each cast instruction independently inhibits merging.
* [Wasm GC] Generalize `skipCast` to work with all type hierarchies (#5422)Thomas Lively2023-01-121-4/+5
| | | | | | | | `skipCast` takes an optional parameter that bounds how general the resulting type is allowed to be. That parameter previously had a default value of `anyref` with the intention of allowing all casts to be skipped, but that default inadvertently prevented any casts in the `func` or `extern` type hierarchies from being skipped. Update `skipCast` so that the default parameter allows all casts to be skipped in all hierarchies.
* [NFC] Remove GCTypeUtils::evaluateKindCheck (#5421)Thomas Lively2023-01-112-70/+33
| | | | | | | | Since we refactored all the old kind-checking instructions to be represented as general cast instructions, `GCTypeUtils::evaluateKindCheck` had become a vestigial wrapper around `GCTypeUtils::evaluateCastCheck` that was only used in RemoveUnusedBrs. Remove `evaluateKindCheck` and use `evaluateCastCheck` in RemoveUnusedBrs without changing any functionality. A future PR may use the extra information from `evaluateCastCheck` to further optimize branching casts.
* [binaryen.js] Avoid use of the global buffer var which emcc has removed (#5419)Alon Zakai2023-01-111-1/+1
|
* [Wasm GC] Handle an unreachable br_on_cast_fail in DCE (#5418)Alon Zakai2023-01-111-1/+4
| | | Without this we hit an assertion on unreachable not being a heap type.
* [Wasm GC] Add missing RefTest optimizations to parallel RefCast (#5417)Alon Zakai2023-01-101-10/+23
| | | | We already handled Success and Failure. Also handle SuccessOnlyIfNull and SuccessOnlyIfNonNull.
* [Wasm GC] Replace `HeapType::data` with `HeapType::struct_` (#5416)Thomas Lively2023-01-1016-196/+126
| | | | | | `struct` has replaced `data` in the upstream spec, so update Binaryen's types to match. We had already supported `struct` as an alias for data, but now remove support for `data` entirely. Also remove instructions like `ref.is_data` that are deprecated and do not make sense without a `data` type.
* Represent ref.as_{func,data,i31} with RefCast (#5413)Thomas Lively2023-01-1016-145/+91
| | | | | | | | | | | | | These operations are deprecated and directly representable as casts, so remove their opcodes in the internal IR and parse them as casts instead. For now, add logic to the printing and binary writing of RefCast to continue emitting the legacy instructions to minimize test changes. The few test changes necessary are because it is no longer valid to perform a ref.as_func on values outside the func type hierarchy now that ref.as_func is subject to the ref.cast validation rules. RefAsExternInternalize, RefAsExternExternalize, and RefAsNonNull are left unmodified. A future PR may remove RefAsNonNull as well, since it is also expressible with casts.
* [NFC] Refactor cast check logic (#5404)Alon Zakai2023-01-102-108/+81
| | | Add a new evaluateCastCheck() utility and use that in relevant places.
* [Wasm GC] Optimize ref.as_non_null of a nullable cast (#5415)Alon Zakai2023-01-101-0/+16
|
* Fix iterator invalidation bug in GlobalStructInference (#5414)Alon Zakai2023-01-101-1/+3
| | | Fixes #5406
* [Wasm GC] More minor cast optimizations (#5402)Alon Zakai2023-01-091-84/+89
| | | | | | | | Look for definitely-failing casts along all the fallthrough values. Specifically, if any cast in the middle proves the final cast will fail, then we know we will trap. Fully optimize redundant casts, considering both the type and the heap type. Combine a cast with a ref.as_non_null.
* Replace `RefIs` with `RefIsNull` (#5401)Thomas Lively2023-01-0928-283/+158
| | | | | | | | | | | | | | | * Replace `RefIs` with `RefIsNull` The other `ref.is*` instructions are deprecated and expressible in terms of `ref.test`. Update binary and text parsing to parse those instructions as `RefTest` expressions. Also update the printing and emitting of `RefTest` expressions to emit the legacy instructions for now to minimize test changes and make this a mostly non-functional change. Since `ref.is_null` is the only `RefIs` instruction left, remove the `RefIsOp` field and rename the expression class to `RefIsNull`. The few test changes are due to the fact that `ref.is*` instructions are now subject to `ref.test` validation, and in particular it is no longer valid to perform a `ref.is_func` on a value outside of the `func` type hierarchy.
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-12 17:33:29 +0000