From 95ddd057424b996a0a2a54f282c6c567246d8cc9 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 28 Aug 2024 09:13:33 -0700 Subject: [NFC] Refactor LocalGraph's core getSets API (#6877) Before we just had a map that people would access with localGraph.getSetses[get], while now it is a call localGraph.getSets(get), which more nicely hides the internal implementation details. Also rename getSetses => getSetsMap. This will allow a later PR to optimize the internals of this API. This is performance-neutral as far as I can measure. (We do replace a direct read from a data structure with a call, but the call is in a header and should always get inlined.) --- src/analysis/reaching-definitions-transfer-function.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/analysis') diff --git a/src/analysis/reaching-definitions-transfer-function.h b/src/analysis/reaching-definitions-transfer-function.h index dcf04e377..7a4fe1afc 100644 --- a/src/analysis/reaching-definitions-transfer-function.h +++ b/src/analysis/reaching-definitions-transfer-function.h @@ -42,7 +42,7 @@ class ReachingDefinitionsTransferFunction std::unordered_map> indexSetses; // LocalGraph members we need to update. - LocalGraph::GetSetses& getSetses; + LocalGraph::GetSetsMap& getSetsMap; // Fictitious LocalSet objects to reprsent a local index obtaining its value // from its default initial value or parameter value. @@ -86,9 +86,9 @@ public: // are working with doesn't contain the correct Expression**s, but this is // left in for future improvements. TODO. ReachingDefinitionsTransferFunction(Function* func, - LocalGraph::GetSetses& getSetses, + LocalGraph::GetSetsMap& getSetsMap, LocalGraph::Locations& locations) - : numLocals(func->getNumLocals()), getSetses(getSetses), + : numLocals(func->getNumLocals()), getSetsMap(getSetsMap), lattice(listLocalSets(func, fakeInitialValueSets, fakeSetPtrs)) { // Map every local index to a set of all the local sets which affect it. @@ -129,9 +129,9 @@ public: if (lattice.exists(currState, setInstance)) { // If a pointer to a real LocalSet, add it, otherwise add a nullptr. if (fakeSetPtrs.find(setInstance) == fakeSetPtrs.end()) { - getSetses[curr].insert(setInstance); + getSetsMap[curr].insert(setInstance); } else { - getSetses[curr].insert(nullptr); + getSetsMap[curr].insert(nullptr); } } } -- cgit v1.2.3