From 83a05025ee883f86cabdf92a9891d6c5ef5afbd4 Mon Sep 17 00:00:00 2001
From: Alon Zakai <alonzakai@gmail.com>
Date: Mon, 23 Oct 2017 09:48:40 -0700
Subject: only look at the |signed| field of loads if it is relevant (#1235)

---
 src/ast/ExpressionAnalyzer.cpp | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

(limited to 'src/ast/ExpressionAnalyzer.cpp')

diff --git a/src/ast/ExpressionAnalyzer.cpp b/src/ast/ExpressionAnalyzer.cpp
index 3556fcdd5..d223bf213 100644
--- a/src/ast/ExpressionAnalyzer.cpp
+++ b/src/ast/ExpressionAnalyzer.cpp
@@ -14,9 +14,9 @@
  * limitations under the License.
  */
 
-#include "ast_utils.h"
 #include "support/hash.h"
-
+#include "ast_utils.h"
+#include "ast/load-utils.h"
 
 namespace wasm {
 // Given a stack of expressions, checks if the topmost is used as a result.
@@ -208,7 +208,10 @@ bool ExpressionAnalyzer::flexibleEqual(Expression* left, Expression* right, Expr
       }
       case Expression::Id::LoadId: {
         CHECK(Load, bytes);
-        CHECK(Load, signed_);
+        if (LoadUtils::isSignRelevant(left->cast<Load>()) &&
+            LoadUtils::isSignRelevant(right->cast<Load>())) {
+          CHECK(Load, signed_);
+        }
         CHECK(Load, offset);
         CHECK(Load, align);
         PUSH(Load, ptr);
@@ -455,7 +458,9 @@ uint32_t ExpressionAnalyzer::hash(Expression* curr) {
       }
       case Expression::Id::LoadId: {
         HASH(Load, bytes);
-        HASH(Load, signed_);
+        if (LoadUtils::isSignRelevant(curr->cast<Load>())) {
+          HASH(Load, signed_);
+        }
         HASH(Load, offset);
         HASH(Load, align);
         PUSH(Load, ptr);
-- 
cgit v1.2.3