From 9c6b8e0f626ade30cee113294019edbdbf29dd36 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Thu, 18 May 2017 10:47:23 -0700 Subject: Validate finalization (#1014) * validate that types are properly finalized, when in pass-debug mode (BINARYEN_PASS_DEBUG env var): check after each pass is run that the type of each node is equal to the proper type (when finalizing it, i.e., fully recomputing the type). * fix many fuzz bugs found by that. * in particular, fix dce bugs with type changes not being fully updated during code removal. add a new TypeUpdater helper class that lets a pass update types efficiently, by the helper tracking deps between blocks and branches etc., and updating/propagating type changes only as necessary. --- src/ast/ExpressionManipulator.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src/ast/ExpressionManipulator.cpp') diff --git a/src/ast/ExpressionManipulator.cpp b/src/ast/ExpressionManipulator.cpp index fb861f0d8..160ff55e1 100644 --- a/src/ast/ExpressionManipulator.cpp +++ b/src/ast/ExpressionManipulator.cpp @@ -147,6 +147,7 @@ void ExpressionManipulator::spliceIntoBlock(Block* block, Index index, Expressio } list[index] = add; } + block->finalize(block->type); } } // namespace wasm -- cgit v1.2.3