From beccdf70258cd99ea25f10af13103e14dc243ffa Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Fri, 15 Jan 2021 18:48:00 +0900 Subject: Basic EH instrucion support for the new spec (#3487) This updates `try`-`catch`-`catch_all` and `rethrow` instructions to match the new spec. `delegate` is not included. Now `Try` contains not a single `catchBody` expression but a vector of catch bodies and events. This updates most existing routines, optimizations, and tests modulo the interpreter and the CFG traversal. Because the interpreter has not been updated yet, the EH spec test is temporarily disabled in check.py. Also, because the CFG traversal for EH is not yet updated, several EH tests in `rse_all-features.wast`, which uses CFG traversal, are temporarily commented out. Also added a few more tests in existing EH test functions in test/passes. In the previous spec, `catch` was catching all exceptions so it was assumed that anything `try` body throws is caught by its `catch`, but now we can assume the same only if there is a `catch_all`. Newly added tests test cases when there is a `catch_all` and cases there are only `catch`es separately. --- src/binaryen-c.cpp | 127 +++++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 109 insertions(+), 18 deletions(-) (limited to 'src/binaryen-c.cpp') diff --git a/src/binaryen-c.cpp b/src/binaryen-c.cpp index 59ca3aebc..f08b5f777 100644 --- a/src/binaryen-c.cpp +++ b/src/binaryen-c.cpp @@ -1200,10 +1200,20 @@ BinaryenExpressionRef BinaryenRefEq(BinaryenModuleRef module, BinaryenExpressionRef BinaryenTry(BinaryenModuleRef module, BinaryenExpressionRef body, - BinaryenExpressionRef catchBody) { + const char** catchEvents_, + BinaryenIndex numCatchEvents, + BinaryenExpressionRef* catchBodies_, + BinaryenIndex numCatchBodies) { + std::vector catchEvents; + std::vector catchBodies; + for (BinaryenIndex i = 0; i < numCatchEvents; i++) { + catchEvents.push_back(catchEvents_[i]); + } + for (BinaryenIndex i = 0; i < numCatchBodies; i++) { + catchBodies.push_back((Expression*)catchBodies_[i]); + } return static_cast( - Builder(*(Module*)module) - .makeTry((Expression*)body, (Expression*)catchBody)); + Builder(*(Module*)module).makeTry(body, catchEvents, catchBodies)); } BinaryenExpressionRef BinaryenThrow(BinaryenModuleRef module, @@ -1219,9 +1229,8 @@ BinaryenExpressionRef BinaryenThrow(BinaryenModuleRef module, } BinaryenExpressionRef BinaryenRethrow(BinaryenModuleRef module, - BinaryenExpressionRef exnref) { - return static_cast( - Builder(*(Module*)module).makeRethrow((Expression*)exnref)); + BinaryenIndex depth) { + return static_cast(Builder(*(Module*)module).makeRethrow(depth)); } BinaryenExpressionRef BinaryenBrOnExn(BinaryenModuleRef module, @@ -2755,17 +2764,101 @@ void BinaryenTrySetBody(BinaryenExpressionRef expr, assert(bodyExpr); static_cast(expression)->body = (Expression*)bodyExpr; } -BinaryenExpressionRef BinaryenTryGetCatchBody(BinaryenExpressionRef expr) { +BinaryenIndex BinaryenTryGetNumCatchEvents(BinaryenExpressionRef expr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + return static_cast(expression)->catchEvents.size(); +} +BinaryenIndex BinaryenTryGetNumCatchBodies(BinaryenExpressionRef expr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + return static_cast(expression)->catchBodies.size(); +} +const char* BinaryenTryGetCatchEventAt(BinaryenExpressionRef expr, + BinaryenIndex index) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(index < static_cast(expression)->catchEvents.size()); + return static_cast(expression)->catchEvents[index].c_str(); +} +void BinaryenTrySetCatchEventAt(BinaryenExpressionRef expr, + BinaryenIndex index, + const char* catchEvent) { auto* expression = (Expression*)expr; assert(expression->is()); - return static_cast(expression)->catchBody; + assert(index < static_cast(expression)->catchEvents.size()); + assert(catchEvent); + static_cast(expression)->catchEvents[index] = catchEvent; } -void BinaryenTrySetCatchBody(BinaryenExpressionRef expr, - BinaryenExpressionRef catchBodyExpr) { +BinaryenIndex BinaryenTryAppendCatchEvent(BinaryenExpressionRef expr, + const char* catchEvent) { auto* expression = (Expression*)expr; assert(expression->is()); - assert(catchBodyExpr); - static_cast(expression)->catchBody = (Expression*)catchBodyExpr; + assert(catchEvent); + auto& list = static_cast(expression)->catchEvents; + auto index = list.size(); + list.push_back(catchEvent); + return index; +} +void BinaryenTryInsertCatchEventAt(BinaryenExpressionRef expr, + BinaryenIndex index, + const char* catchEvent) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(catchEvent); + static_cast(expression)->catchEvents.insertAt(index, catchEvent); +} +const char* BinaryenTryRemoveCatchEventAt(BinaryenExpressionRef expr, + BinaryenIndex index) { + auto* expression = (Expression*)expr; + assert(expression->is()); + return static_cast(expression)->catchEvents.removeAt(index).c_str(); +} +BinaryenExpressionRef BinaryenTryGetCatchBodyAt(BinaryenExpressionRef expr, + BinaryenIndex index) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(index < static_cast(expression)->catchBodies.size()); + return static_cast(expression)->catchBodies[index]; +} +void BinaryenTrySetCatchBodyAt(BinaryenExpressionRef expr, + BinaryenIndex index, + BinaryenExpressionRef catchExpr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(index < static_cast(expression)->catchBodies.size()); + assert(catchExpr); + static_cast(expression)->catchBodies[index] = (Expression*)catchExpr; +} +BinaryenIndex BinaryenTryAppendCatchBody(BinaryenExpressionRef expr, + BinaryenExpressionRef catchExpr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(catchExpr); + auto& list = static_cast(expression)->catchBodies; + auto index = list.size(); + list.push_back((Expression*)catchExpr); + return index; +} +void BinaryenTryInsertCatchBodyAt(BinaryenExpressionRef expr, + BinaryenIndex index, + BinaryenExpressionRef catchExpr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + assert(catchExpr); + static_cast(expression) + ->catchBodies.insertAt(index, (Expression*)catchExpr); +} +BinaryenExpressionRef BinaryenTryRemoveCatchBodyAt(BinaryenExpressionRef expr, + BinaryenIndex index) { + auto* expression = (Expression*)expr; + assert(expression->is()); + return static_cast(expression)->catchBodies.removeAt(index); +} +int BinaryenTryHasCatchAll(BinaryenExpressionRef expr) { + auto* expression = (Expression*)expr; + assert(expression->is()); + return static_cast(expression)->hasCatchAll(); } // Throw const char* BinaryenThrowGetEvent(BinaryenExpressionRef expr) { @@ -2825,17 +2918,15 @@ BinaryenExpressionRef BinaryenThrowRemoveOperandAt(BinaryenExpressionRef expr, return static_cast(expression)->operands.removeAt(index); } // Rethrow -BinaryenExpressionRef BinaryenRethrowGetExnref(BinaryenExpressionRef expr) { +BinaryenIndex BinaryenRethrowGetDepth(BinaryenExpressionRef expr) { auto* expression = (Expression*)expr; assert(expression->is()); - return static_cast(expression)->exnref; + return static_cast(expression)->depth; } -void BinaryenRethrowSetExnref(BinaryenExpressionRef expr, - BinaryenExpressionRef exnrefExpr) { +void BinaryenRethrowSetDepth(BinaryenExpressionRef expr, BinaryenIndex depth) { auto* expression = (Expression*)expr; assert(expression->is()); - assert(exnrefExpr); - static_cast(expression)->exnref = (Expression*)exnrefExpr; + static_cast(expression)->depth = depth; } // BrOnExn const char* BinaryenBrOnExnGetEvent(BinaryenExpressionRef expr) { -- cgit v1.2.3