From e3c38c14e7dd9c115da960daafd109d2687f1a08 Mon Sep 17 00:00:00 2001
From: JF Bastien <jfb@chromium.org>
Date: Sun, 10 Jan 2016 10:49:59 -0800
Subject: Add Travis builds with sanitizers

This triggers 5 independent build / test runs:
 - clang, no sanitizer;
 - clang, UB sanitizer;
 - clang, address sanitizer (disabled for now);
 - clang, thread sanitizer (disabled for now);
 - GCC.

Enabling UBSan led to these changes:
 - Fix a bunch of undefined behavior throughout the code base.
 - Fix some tests that relied on that undefined behavior.
 - Make some of the tests easier to debug by printing their command line.
 - Add ubsan blacklist to work around libstdc++ bug.
 - Example testcase also needs sanitizer because libsupport.a uses it.
---
 src/emscripten-optimizer/parser.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

(limited to 'src/emscripten-optimizer/parser.h')

diff --git a/src/emscripten-optimizer/parser.h b/src/emscripten-optimizer/parser.h
index c805ca9f6..da3e6f5c7 100644
--- a/src/emscripten-optimizer/parser.h
+++ b/src/emscripten-optimizer/parser.h
@@ -22,13 +22,14 @@
 #ifndef wasm_parser_h
 #define wasm_parser_h
 
-#include <vector>
-#include <iostream>
 #include <algorithm>
-
-#include <stdio.h>
+#include <cstdio>
+#include <iostream>
+#include <limits>
+#include <vector>
 
 #include "istring.h"
+#include "support/safe_integer.h"
 
 namespace cashew {
 
@@ -179,10 +180,6 @@ class Parser {
 
   static bool hasChar(const char* list, char x) { while (*list) if (*list++ == x) return true; return false; }
 
-  static bool is32Bit(double x) {
-    return x == (int)x || x == (unsigned int)x;
-  }
-
   // An atomic fragment of something. Stops at a natural boundary.
   enum FragType {
     KEYWORD = 0,
@@ -249,7 +246,10 @@ class Parser {
         // for valid asm.js input, the '.' should be enough, and for uglify
         // in the emscripten optimizer pipeline, we use simple_ast where INT/DOUBLE
         // is quite the same at this point anyhow
-        type = (std::find(start, src, '.') == src && is32Bit(num)) ? INT : DOUBLE;
+        type = (std::find(start, src, '.') == src &&
+                (wasm::isSInteger32(num) || wasm::isUInteger32(num)))
+                   ? INT
+                   : DOUBLE;
         assert(src > start);
       } else if (hasChar(OPERATOR_INITS, *src)) {
         switch (*src) {
-- 
cgit v1.2.3