From 1a3c1a58cc7e97a846f612baf7f74a370980458f Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Tue, 21 May 2019 13:25:14 -0700 Subject: Reflect instruction renaming in code (#2128) - Reflected new renamed instruction names in code and tests: - `get_local` -> `local.get` - `set_local` -> `local.set` - `tee_local` -> `local.tee` - `get_global` -> `global.get` - `set_global` -> `global.set` - `current_memory` -> `memory.size` - `grow_memory` -> `memory.grow` - Removed APIs related to old instruction names in Binaryen.js and added APIs with new names if they are missing. - Renamed `typedef SortedVector LocalSet` to `SetsOfLocals` to prevent name clashes. - Resolved several TODO renaming items in wasm-binary.h: - `TableSwitch` -> `BrTable` - `I32ConvertI64` -> `I32WrapI64` - `I64STruncI32` -> `I64SExtendI32` - `I64UTruncI32` -> `I64UExtendI32` - `F32ConvertF64` -> `F32DemoteI64` - `F64ConvertF32` -> `F64PromoteF32` - Renamed `BinaryenGetFeatures` and `BinaryenSetFeatures` to `BinaryenModuleGetFeatures` and `BinaryenModuleSetFeatures` for consistency. --- src/ir/ExpressionAnalyzer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/ir/ExpressionAnalyzer.cpp') diff --git a/src/ir/ExpressionAnalyzer.cpp b/src/ir/ExpressionAnalyzer.cpp index de37cd08b..32e763a45 100644 --- a/src/ir/ExpressionAnalyzer.cpp +++ b/src/ir/ExpressionAnalyzer.cpp @@ -136,12 +136,12 @@ template void visitImmediates(Expression* curr, T& visitor) { void visitCallIndirect(CallIndirect* curr) { visitor.visitNonScopeName(curr->fullType); } - void visitGetLocal(GetLocal* curr) { visitor.visitIndex(curr->index); } - void visitSetLocal(SetLocal* curr) { visitor.visitIndex(curr->index); } - void visitGetGlobal(GetGlobal* curr) { + void visitLocalGet(LocalGet* curr) { visitor.visitIndex(curr->index); } + void visitLocalSet(LocalSet* curr) { visitor.visitIndex(curr->index); } + void visitGlobalGet(GlobalGet* curr) { visitor.visitNonScopeName(curr->name); } - void visitSetGlobal(SetGlobal* curr) { + void visitGlobalSet(GlobalSet* curr) { visitor.visitNonScopeName(curr->name); } void visitLoad(Load* curr) { -- cgit v1.2.3