From 6ddacde514af7cc546caa07fede4baa3e429c33c Mon Sep 17 00:00:00 2001
From: Thomas Lively <tlively@google.com>
Date: Fri, 20 Dec 2024 17:45:47 -0800
Subject: [NFC] Make MemoryOrder parameters non-optional (#7171)
Update Builder and IRBuilder makeStructGet and makeStructSet functions
to require the memory order to be explicitly supplied. This is slightly
more verbose, but will reduce the chances that we forget to properly
consider synchronization when implementing new features in the future.
---
src/parser/contexts.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
(limited to 'src/parser/contexts.h')
diff --git a/src/parser/contexts.h b/src/parser/contexts.h
index a65299eac..2f008c019 100644
--- a/src/parser/contexts.h
+++ b/src/parser/contexts.h
@@ -740,15 +740,12 @@ struct NullInstrParserCtx {
HeapTypeT,
FieldIdxT,
bool,
- MemoryOrder = MemoryOrder::Unordered) {
+ MemoryOrder) {
return Ok{};
}
template<typename HeapTypeT>
- Result<> makeStructSet(Index,
- const std::vector<Annotation>&,
- HeapTypeT,
- FieldIdxT,
- MemoryOrder = MemoryOrder::Unordered) {
+ Result<> makeStructSet(
+ Index, const std::vector<Annotation>&, HeapTypeT, FieldIdxT, MemoryOrder) {
return Ok{};
}
template<typename HeapTypeT>
--
cgit v1.2.3