From 368c1edf2a6182dcde7a91e6facbf3dbdd6c7456 Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Fri, 15 Nov 2024 16:18:29 -0500 Subject: Mark Result and MaybeResult [[nodiscard]] (#7083) Since these types may be carrying errors that need to be handled or propagated, it is always an error not to use them in some way. Adding the [[nodiscard]] attribute caused the compiler to find a few instances where we were incorrectly ignoring results. Fix these places. --- src/parser/parsers.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/parser/parsers.h') diff --git a/src/parser/parsers.h b/src/parser/parsers.h index 4121788d7..2d3321dcd 100644 --- a/src/parser/parsers.h +++ b/src/parser/parsers.h @@ -1099,7 +1099,7 @@ block(Ctx& ctx, const std::vector& annotations, bool folded) { auto type = blocktype(ctx); CHECK_ERR(type); - ctx.makeBlock(pos, annotations, label, *type); + CHECK_ERR(ctx.makeBlock(pos, annotations, label, *type)); CHECK_ERR(instrs(ctx)); @@ -1162,7 +1162,7 @@ ifelse(Ctx& ctx, const std::vector& annotations, bool folded) { return ctx.in.err("else label does not match if label"); } - ctx.visitElse(); + CHECK_ERR(ctx.visitElse()); CHECK_ERR(instrs(ctx)); @@ -1205,7 +1205,7 @@ loop(Ctx& ctx, const std::vector& annotations, bool folded) { auto type = blocktype(ctx); CHECK_ERR(type); - ctx.makeLoop(pos, annotations, label, *type); + CHECK_ERR(ctx.makeLoop(pos, annotations, label, *type)); CHECK_ERR(instrs(ctx)); -- cgit v1.2.3