From 3732f36ce062c3ee60413e4c19667f256b9297f8 Mon Sep 17 00:00:00 2001
From: Alon Zakai <azakai@google.com>
Date: Tue, 20 Oct 2020 10:46:20 -0700
Subject: Warn on memory segment overlaps (#3257)

We may fix this eventually, but it appears to not be urgent. For now at least
show a warning so toolchains have a chance to see there is something
they should fix.
---
 src/passes/MemoryPacking.cpp | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'src/passes/MemoryPacking.cpp')

diff --git a/src/passes/MemoryPacking.cpp b/src/passes/MemoryPacking.cpp
index 3ab170ea9..6003274e8 100644
--- a/src/passes/MemoryPacking.cpp
+++ b/src/passes/MemoryPacking.cpp
@@ -232,6 +232,8 @@ bool MemoryPacking::canOptimize(const std::vector<Memory::Segment>& segments) {
       Address start = c->value.getInteger();
       DisjointSpans::Span span{start, start + segment.data.size()};
       if (space.addAndCheckOverlap(span)) {
+        std::cerr << "warning: active memory segments have overlap, which "
+                  << "prevents some optimizations.\n";
         return false;
       }
     }
-- 
cgit v1.2.3