From 2055ea3fd0391c1abb92cdec54f32274dc7fd971 Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Fri, 30 Sep 2022 18:17:45 -0500 Subject: Refactor interaction between Pass and PassRunner (#5093) Previously only WalkerPasses had access to the `getPassRunner` and `getPassOptions` methods. Move those methods to `Pass` so all passes can use them. As a result, the `PassRunner` passed to `Pass::run` and `Pass::runOnFunction` is no longer necessary, so remove it. Also update `Pass::create` to return a unique_ptr, which is more efficient than having it return a raw pointer only to have the `PassRunner` wrap that raw pointer in a `unique_ptr`. Delete the unused template `PassRunner::getLast()`, which looks like it was intended to enable retrieving previous analyses and has been in the code base since 2015 but is not implemented anywhere. --- src/passes/PrintCallGraph.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/passes/PrintCallGraph.cpp') diff --git a/src/passes/PrintCallGraph.cpp b/src/passes/PrintCallGraph.cpp index 79938e650..6022c8703 100644 --- a/src/passes/PrintCallGraph.cpp +++ b/src/passes/PrintCallGraph.cpp @@ -33,7 +33,7 @@ namespace wasm { struct PrintCallGraph : public Pass { bool modifiesBinaryenIR() override { return false; } - void run(PassRunner* runner, Module* module) override { + void run(Module* module) override { std::ostream& o = std::cout; o << "digraph call {\n" " rankdir = LR;\n" -- cgit v1.2.3