From 3b9c2e85fa5d97ba08a95c0c7cce7d041e699cde Mon Sep 17 00:00:00 2001 From: Ashley Nelson Date: Tue, 21 Jun 2022 20:57:43 -0700 Subject: First class Data Segments (#4733) * Updating wasm.h/cpp for DataSegments * Updating wasm-binary.h/cpp for DataSegments * Removed link from Memory to DataSegments and updated module-utils, Metrics and wasm-traversal * checking isPassive when copying data segments to know whether to construct the data segment with an offset or not * Removing memory member var from DataSegment class as there is only one memory rn. Updated wasm-validator.cpp * Updated wasm-interpreter * First look at updating Passes * Updated wasm-s-parser * Updated files in src/ir * Updating tools files * Last pass on src files before building * added visitDataSegment * Fixing build errors * Data segments need a name * fixing var name * ran clang-format * Ensuring a name on DataSegment * Ensuring more datasegments have names * Adding explicit name support * Fix fuzzing name * Outputting data name in wasm binary only if explicit * Checking temp dataSegments vector to validateBinary because it's the one with the segments before we processNames * Pass on when data segment names are explicitly set * Ran auto_update_tests.py and check.py, success all around * Removed an errant semi-colon and corrected a counter. Everything still passes * Linting * Fixing processing memory names after parsed from binary * Updating the test from the last fix * Correcting error comment * Impl kripken@ comments * Impl tlively@ comments * Updated tests that remove data print when == 0 * Ran clang format * Impl tlively@ comments * Ran clang-format --- src/passes/RemoveMemory.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/passes/RemoveMemory.cpp') diff --git a/src/passes/RemoveMemory.cpp b/src/passes/RemoveMemory.cpp index 399a32933..6f2f9aee7 100644 --- a/src/passes/RemoveMemory.cpp +++ b/src/passes/RemoveMemory.cpp @@ -25,7 +25,7 @@ namespace wasm { struct RemoveMemory : public Pass { void run(PassRunner* runner, Module* module) override { - module->memory.segments.clear(); + module->removeDataSegments([&](DataSegment* curr) { return true; }); } }; -- cgit v1.2.3