From 326bfcd7d9f6927e28d106a6cd6e9c408a0f6a0d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Tue, 21 May 2024 13:06:01 -0700 Subject: Fuzzer: Better fuzzing of globals (#6611) With this PR we generate global.gets in globals, which we did not do before. We do that by replacing makeConst (the only thing we did before, for the contents of globals) with makeTrivial, and add code to makeTrivial to sometimes make a global.get. When no suitable global exists, makeGlobalGet will emit a constant, so there is no danger in trying. Also raise the number of globals a little. Also explicitly note the current limitation of requiring all tuple globals to contain tuple.make and nothing else, including not global.get, and avoid adding such invalid global.gets in tuple globals in the fuzzer. --- src/support/topological_sort.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/support/topological_sort.h') diff --git a/src/support/topological_sort.h b/src/support/topological_sort.h index 91353dd37..3594617eb 100644 --- a/src/support/topological_sort.h +++ b/src/support/topological_sort.h @@ -27,7 +27,7 @@ namespace wasm { // CRTP utility that provides an iterator through arbitrary directed acyclic // graphs of data that will visit the data in a topologically sorted order // (https://en.wikipedia.org/wiki/Topological_sorting). In other words, the -// iterator will produce each item only after all that items predecessors have +// iterator will produce each item only after all that item's predecessors have // been produced. // // Subclasses should call `push` on all the root items in their constructors and -- cgit v1.2.3