From 119525ea6078c9af697de0038407ab541f3d4c12 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 23 Jan 2019 16:15:38 -0800 Subject: Validate unique local names, and use validation in wasm2js. Fixes #1885 (#1886) * Also fixes some bugs in wasm2js tests that did not validate. * Rename FeatureOptions => ToolOptions, as they now contain all the basic stuff each tool needs for commandline options (validation yes or no, and which features if so). --- src/tools/optimization-options.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'src/tools/optimization-options.h') diff --git a/src/tools/optimization-options.h b/src/tools/optimization-options.h index 7849be375..53fd60e4d 100644 --- a/src/tools/optimization-options.h +++ b/src/tools/optimization-options.h @@ -14,7 +14,7 @@ * limitations under the License. */ -#include "feature-options.h" +#include "tool-options.h" // // Shared optimization options for commandline tools @@ -22,12 +22,12 @@ namespace wasm { -struct OptimizationOptions : public FeatureOptions { +struct OptimizationOptions : public ToolOptions { static constexpr const char* DEFAULT_OPT_PASSES = "O"; std::vector passes; - OptimizationOptions(const std::string& command, const std::string& description) : FeatureOptions(command, description) { + OptimizationOptions(const std::string& command, const std::string& description) : ToolOptions(command, description) { (*this).add("", "-O", "execute default optimization passes", Options::Arguments::Zero, [this](Options*, const std::string&) { @@ -92,11 +92,6 @@ struct OptimizationOptions : public FeatureOptions { [this](Options* o, const std::string& argument) { passOptions.shrinkLevel = atoi(argument.c_str()); }) - .add("--no-validation", "-n", "Disables validation, assumes inputs are correct", - Options::Arguments::Zero, - [this](Options* o, const std::string& argument) { - passOptions.validate = false; - }) .add("--ignore-implicit-traps", "-iit", "Optimize under the helpful assumption that no surprising traps occur (from load, div/mod, etc.)", Options::Arguments::Zero, [this](Options*, const std::string&) { -- cgit v1.2.3