From 6ddacde514af7cc546caa07fede4baa3e429c33c Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Fri, 20 Dec 2024 17:45:47 -0800 Subject: [NFC] Make MemoryOrder parameters non-optional (#7171) Update Builder and IRBuilder makeStructGet and makeStructSet functions to require the memory order to be explicitly supplied. This is slightly more verbose, but will reduce the chances that we forget to properly consider synchronization when implementing new features in the future. --- src/wasm-ir-builder.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'src/wasm-ir-builder.h') diff --git a/src/wasm-ir-builder.h b/src/wasm-ir-builder.h index a40e8df82..c46f9f2ca 100644 --- a/src/wasm-ir-builder.h +++ b/src/wasm-ir-builder.h @@ -204,13 +204,9 @@ public: makeBrOn(Index label, BrOnOp op, Type in = Type::none, Type out = Type::none); Result<> makeStructNew(HeapType type); Result<> makeStructNewDefault(HeapType type); - Result<> makeStructGet(HeapType type, - Index field, - bool signed_, - MemoryOrder order = MemoryOrder::Unordered); - Result<> makeStructSet(HeapType type, - Index field, - MemoryOrder order = MemoryOrder::Unordered); + Result<> + makeStructGet(HeapType type, Index field, bool signed_, MemoryOrder order); + Result<> makeStructSet(HeapType type, Index field, MemoryOrder order); Result<> makeArrayNew(HeapType type); Result<> makeArrayNewDefault(HeapType type); Result<> makeArrayNewData(HeapType type, Name data); -- cgit v1.2.3