From 4536c4935aa936505c56d600c78e814a07393430 Mon Sep 17 00:00:00 2001
From: Alon Zakai <alonzakai@gmail.com>
Date: Sat, 31 Oct 2015 21:25:49 -0700
Subject: better error on bad # of params

---
 src/wasm-js.cpp | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

(limited to 'src/wasm-js.cpp')

diff --git a/src/wasm-js.cpp b/src/wasm-js.cpp
index 36ce6c4c7..2ee6e9683 100644
--- a/src/wasm-js.cpp
+++ b/src/wasm-js.cpp
@@ -167,8 +167,17 @@ extern "C" double EMSCRIPTEN_KEEPALIVE call_from_js(const char *target) {
   assert(instance->functions.find(name) != instance->functions.end());
   Function *function = instance->functions[name];
   size_t num = EM_ASM_INT_V({ return Module['tempArguments'].length });
-  assert(num == function->params.size()); // TODO: fake missing/extra args?
-
+  if (num != function->params.size()) {
+    std::cerr << "warning: bad # of arguments to " << target << ": got " << num << ", but expect " << function->params.size() << '\n';
+    abort(); // TODO: fake missing/extra args?
+#if 0
+    if (num > function->params.size()) {
+      num = function->params.size(); // ignore the rest
+    } else {
+      .. fake missing ..
+    }
+#endif
+  }
   ModuleInstance::LiteralList arguments;
   for (size_t i = 0; i < num; i++) {
     WasmType type = function->params[i].type;
-- 
cgit v1.2.3