From 77b998fc2711a1f46e699d581c50a6cf9d50c7c2 Mon Sep 17 00:00:00 2001 From: Jukka Jylänki Date: Mon, 28 Mar 2016 15:11:36 +0300 Subject: Hide Visual Studio build warning on casting 64-bit int to 32-bit when we know it is safe to do so. --- src/wasm-s-parser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/wasm-s-parser.h') diff --git a/src/wasm-s-parser.h b/src/wasm-s-parser.h index 965336857..4c22fb1e3 100644 --- a/src/wasm-s-parser.h +++ b/src/wasm-s-parser.h @@ -826,7 +826,7 @@ private: } else if (str[0] == 'o') { uint64_t offset = atoll(eq); if (offset > 0xffffffff) onError(); - ret->offset = offset; + ret->offset = (uint32_t)offset; } else onError(); i++; } -- cgit v1.2.3 From 246c58952f4f56ebc9614459b218cbc885dd13d4 Mon Sep 17 00:00:00 2001 From: Jukka Jylänki Date: Mon, 28 Mar 2016 21:33:03 +0300 Subject: Use std::numeric_limits::max() instead of 0xFFFFFFFF. --- src/support/file.cpp | 5 +++-- src/wasm-s-parser.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'src/wasm-s-parser.h') diff --git a/src/support/file.cpp b/src/support/file.cpp index 0401ea724..da7054f7f 100644 --- a/src/support/file.cpp +++ b/src/support/file.cpp @@ -17,6 +17,7 @@ #include "support/file.h" #include +#include template T wasm::read_file(const std::string &filename, bool debug) { @@ -27,8 +28,8 @@ T wasm::read_file(const std::string &filename, bool debug) { exit(EXIT_FAILURE); } infile.seekg(0, std::ios::end); - std::streamoff insize = infile.tellg(); - if (sizeof(size_t) == 4 && insize >= 0xFFFFFFFFU) { + std::streampos insize = infile.tellg(); + if (insize >= std::numeric_limits::max()) { // Building a 32-bit executable where size_t == 32 bits, we are not able to create strings larger than 2^32 bytes in length, so must abort here. std::cerr << "Failed opening '" << filename << "': Input file too large: " << insize << " bytes. Try rebuilding in 64-bit mode." << std::endl; exit(EXIT_FAILURE); diff --git a/src/wasm-s-parser.h b/src/wasm-s-parser.h index 4c22fb1e3..c3f32e809 100644 --- a/src/wasm-s-parser.h +++ b/src/wasm-s-parser.h @@ -23,6 +23,7 @@ #define wasm_wasm_s_parser_h #include +#include #include "wasm.h" #include "mixed_arena.h" @@ -825,7 +826,7 @@ private: ret->align = atoi(eq); } else if (str[0] == 'o') { uint64_t offset = atoll(eq); - if (offset > 0xffffffff) onError(); + if (offset > std::numeric_limits::max()) onError(); ret->offset = (uint32_t)offset; } else onError(); i++; -- cgit v1.2.3 From cefb6b6e05c985524e885af17160b9e146f9b088 Mon Sep 17 00:00:00 2001 From: Jukka Jylänki Date: Mon, 28 Mar 2016 21:38:54 +0300 Subject: Add missing include. # Conflicts: # src/wasm-s-parser.h --- src/wasm-s-parser.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/wasm-s-parser.h') diff --git a/src/wasm-s-parser.h b/src/wasm-s-parser.h index c3f32e809..575ceff97 100644 --- a/src/wasm-s-parser.h +++ b/src/wasm-s-parser.h @@ -23,6 +23,7 @@ #define wasm_wasm_s_parser_h #include +#include #include #include "wasm.h" -- cgit v1.2.3