From 570007dbecf86db5ddba8d303896d841fc2b2d27 Mon Sep 17 00:00:00 2001
From: Thomas Lively <tlively@google.com>
Date: Wed, 16 Nov 2022 13:44:33 -0800
Subject: Revert "Make `call_ref` type annotations mandatory (#5246)" (#5265)

This reverts commit b2054b72b7daa89b7ad161c0693befad06a20c90.

It looks like the necessary V8 change has not rolled out everywhere yet.
---
 src/wasm/wasm-s-parser.cpp | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

(limited to 'src/wasm/wasm-s-parser.cpp')

diff --git a/src/wasm/wasm-s-parser.cpp b/src/wasm/wasm-s-parser.cpp
index ab6230442..a9fd2de77 100644
--- a/src/wasm/wasm-s-parser.cpp
+++ b/src/wasm/wasm-s-parser.cpp
@@ -2744,20 +2744,35 @@ Expression* SExpressionWasmBuilder::makeTupleExtract(Element& s) {
 }
 
 Expression* SExpressionWasmBuilder::makeCallRef(Element& s, bool isReturn) {
-  HeapType sigType = parseHeapType(*s[1]);
+  Index operandsStart = 1;
+  std::optional<HeapType> sigType;
+  try {
+    sigType = parseHeapType(*s[1]);
+    operandsStart = 2;
+  } catch (ParseException& p) {
+    // The type annotation is required for return_call_ref but temporarily
+    // optional for call_ref.
+    if (isReturn) {
+      throw;
+    }
+  }
   std::vector<Expression*> operands;
-  parseOperands(s, 2, s.size() - 1, operands);
+  parseOperands(s, operandsStart, s.size() - 1, operands);
   auto* target = parseExpression(s[s.size() - 1]);
 
-  if (!sigType.isSignature()) {
-    throw ParseException(
-      std::string(isReturn ? "return_call_ref" : "call_ref") +
-        " type annotation should be a signature",
-      s.line,
-      s.col);
+  if (sigType) {
+    if (!sigType->isSignature()) {
+      throw ParseException(
+        std::string(isReturn ? "return_call_ref" : "call_ref") +
+          " type annotation should be a signature",
+        s.line,
+        s.col);
+    }
+    return Builder(wasm).makeCallRef(
+      target, operands, sigType->getSignature().results, isReturn);
   }
-  return Builder(wasm).makeCallRef(
-    target, operands, sigType.getSignature().results, isReturn);
+  return ValidatingBuilder(wasm, s.line, s.col)
+    .validateAndMakeCallRef(target, operands, isReturn);
 }
 
 Expression* SExpressionWasmBuilder::makeI31New(Element& s) {
-- 
cgit v1.2.3