From 594ff7b9609656edb83187cb4600b23b3f2fde37 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Tue, 23 Aug 2022 13:02:52 -0700 Subject: Only look at the relevant parameter in param-utils:removeParameter (#4937) Followup to #4910. --- src/passes/param-utils.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/passes/param-utils.cpp b/src/passes/param-utils.cpp index 3b0721173..e94ea95b1 100644 --- a/src/passes/param-utils.cpp +++ b/src/passes/param-utils.cpp @@ -79,11 +79,8 @@ bool removeParameter(const std::vector& funcs, bool hasUnremovable = EffectAnalyzer(runner->options, *module, operands[index]) .hasUnremovableSideEffects(); - bool wouldChangeType = - call->type == Type::unreachable && !call->isReturn && - std::any_of(operands.begin(), operands.end(), [](Expression* operand) { - return operand->type == Type::unreachable; - }); + bool wouldChangeType = call->type == Type::unreachable && !call->isReturn && + operands[index]->type == Type::unreachable; return hasUnremovable || wouldChangeType; }; bool callParamsAreValid = -- cgit v1.2.3