From 622cba9c49378f89ca94e05cbbe2af0b0c62ab44 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Thu, 15 Nov 2018 10:06:39 -0800 Subject: Don't try to optimize away unused names in RemoveUnusedBrs (#1750) Rely on the dedicated pass for that. It's not worth the extra complexity to try, as we can't easily handle all the cases anyhow. Add another run of the dedicated name-removing pass in the default passes. --- src/passes/RemoveUnusedBrs.cpp | 1 - src/passes/pass.cpp | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/passes/RemoveUnusedBrs.cpp b/src/passes/RemoveUnusedBrs.cpp index ce839a646..ccdf55794 100644 --- a/src/passes/RemoveUnusedBrs.cpp +++ b/src/passes/RemoveUnusedBrs.cpp @@ -668,7 +668,6 @@ struct RemoveUnusedBrs : public WalkerPass> { builder.makeUnary(EqZInt32, br->condition), curr )); - curr->name = Name(); ExpressionManipulator::nop(br); curr->finalize(curr->type); } else { diff --git a/src/passes/pass.cpp b/src/passes/pass.cpp index 577ccd36a..26f771277 100644 --- a/src/passes/pass.cpp +++ b/src/passes/pass.cpp @@ -184,7 +184,8 @@ void PassRunner::addDefaultFunctionOptimizationPasses() { add("code-folding"); } add("merge-blocks"); // makes remove-unused-brs more effective - add("remove-unused-brs"); // coalesce-locals opens opportunities for optimizations + add("remove-unused-brs"); // coalesce-locals opens opportunities + add("remove-unused-names"); // remove-unused-brs opens opportunities add("merge-blocks"); // clean up remove-unused-brs new blocks add("optimize-instructions"); // late propagation -- cgit v1.2.3