From 8c99af063794e022f22dfb013f99ec25857ace5f Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Mon, 29 Apr 2024 13:32:46 -0700 Subject: [Strings] wasm-ctor-eval: Stop on seeing a string view, which we cannot precompute (#6561) --- src/tools/wasm-ctor-eval.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src') diff --git a/src/tools/wasm-ctor-eval.cpp b/src/tools/wasm-ctor-eval.cpp index a806333af..4018be0e7 100644 --- a/src/tools/wasm-ctor-eval.cpp +++ b/src/tools/wasm-ctor-eval.cpp @@ -93,6 +93,14 @@ public: // serialize them.) throw FailToEvalException("table.set: TODO"); } + + Flow visitStringAs(StringAs* curr) { + // TODO: It is not clear how we can handle string.as, since it can lead to + // us needing string_views in globals, but string.as is not a constant + // instruction, so we cannot generate such globals atm. Perhaps we + // could generate them in the start function? + throw FailToEvalException("string.as: TODO"); + } }; // Build an artificial `env` module based on a module's imports, so that the -- cgit v1.2.3