From 93883fde36ac158fd415dcd6dbd387dcfd928d3c Mon Sep 17 00:00:00 2001
From: Alon Zakai <azakai@google.com>
Date: Mon, 14 Oct 2024 16:07:57 -0700
Subject: [WasmGC] OptimizeInstructions: Cancel out internalize+externalize
 pairs (#7005)

---
 src/passes/OptimizeInstructions.cpp | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/passes/OptimizeInstructions.cpp b/src/passes/OptimizeInstructions.cpp
index 64d59ca1d..e1478b54f 100644
--- a/src/passes/OptimizeInstructions.cpp
+++ b/src/passes/OptimizeInstructions.cpp
@@ -2266,9 +2266,19 @@ struct OptimizeInstructions
           refAsChild->value = curr;
           refAsChild->finalize();
           replaceCurrent(refAsChild);
+          return;
+        }
+
+        // We can optimize away externalizations of internalizations and vice
+        // versa.
+        if ((curr->op == ExternConvertAny &&
+             refAsChild->op == AnyConvertExtern) ||
+            (curr->op == AnyConvertExtern &&
+             refAsChild->op == ExternConvertAny)) {
+          replaceCurrent(refAsChild->value);
+          return;
         }
       }
-      // TODO: optimize away ExternConvertAny of AnyConvertExtern, etc.
       return;
     }
 
-- 
cgit v1.2.3