From c2007eab91ed60ac4bc8a6a555e9dc3e76ef2242 Mon Sep 17 00:00:00 2001
From: Thomas Lively <7121787+tlively@users.noreply.github.com>
Date: Fri, 27 Aug 2021 10:36:12 -0700
Subject: Read from stdin when the input file is `-` (#4106)

We already supported `-` as meaning stdout for output and this is useful in
similar situations. Fixes #4105.
---
 src/support/command-line.cpp |  6 ++++--
 src/support/file.cpp         | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

(limited to 'src')

diff --git a/src/support/command-line.cpp b/src/support/command-line.cpp
index 355d704bb..d9b7170f5 100644
--- a/src/support/command-line.cpp
+++ b/src/support/command-line.cpp
@@ -124,16 +124,18 @@ void Options::parse(int argc, const char* argv[]) {
   assert(argc > 0 && "expect at least program name as an argument");
   size_t positionalsSeen = 0;
   auto dashes = [](const std::string& s) {
-    for (size_t i = 0;; ++i) {
+    for (size_t i = 0; i < s.size(); ++i) {
       if (s[i] != '-') {
         return i;
       }
     }
+    return s.size();
   };
   for (size_t i = 1, e = argc; i != e; ++i) {
     std::string currentOption = argv[i];
 
-    if (dashes(currentOption) == 0) {
+    // "-" alone is a positional option
+    if (dashes(currentOption) == 0 || currentOption == "-") {
       // Positional.
       switch (positional) {
         case Arguments::Zero:
diff --git a/src/support/file.cpp b/src/support/file.cpp
index d17e3a338..dc9707a1b 100644
--- a/src/support/file.cpp
+++ b/src/support/file.cpp
@@ -34,8 +34,22 @@ std::vector<char> wasm::read_stdin() {
   return input;
 }
 
+template<typename T> struct do_read_stdin { T operator()(); };
+
+template<> std::vector<char> do_read_stdin<std::vector<char>>::operator()() {
+  return wasm::read_stdin();
+}
+
+template<> std::string do_read_stdin<std::string>::operator()() {
+  auto vec = wasm::read_stdin();
+  return std::string(vec.begin(), vec.end());
+}
+
 template<typename T>
 T wasm::read_file(const std::string& filename, Flags::BinaryOption binary) {
+  if (filename == "-") {
+    return do_read_stdin<T>{}();
+  }
   BYN_TRACE("Loading '" << filename << "'...\n");
   std::ifstream infile;
   std::ios_base::openmode flags = std::ifstream::in;
-- 
cgit v1.2.3