From cc0ccef87716fd8223fc16793c9ec3bc3249da13 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 6 Feb 2019 12:58:43 -0800 Subject: fix binaryen.js bindings handling of literals (#1896) The hardcoded 16 size was no longer valid. This was broken for a while, but happened to not overwrite important memory. Testing with the wasm backend did hit breakage. --- test/binaryen.js/kitchen-sink.js | 5 +++++ test/binaryen.js/kitchen-sink.js.txt | 1 + 2 files changed, 6 insertions(+) (limited to 'test/binaryen.js') diff --git a/test/binaryen.js/kitchen-sink.js b/test/binaryen.js/kitchen-sink.js index c5c919035..6c97703f9 100644 --- a/test/binaryen.js/kitchen-sink.js +++ b/test/binaryen.js/kitchen-sink.js @@ -741,6 +741,10 @@ function test_parsing() { module2.dispose(); } +function test_internals() { + console.log('sizeof Literal: ' + Binaryen['_BinaryenSizeofLiteral']()); +} + function main() { test_types(); test_ids(); @@ -751,6 +755,7 @@ function main() { test_nonvalid(); test_tracing(); test_parsing(); + test_internals(); } main(); diff --git a/test/binaryen.js/kitchen-sink.js.txt b/test/binaryen.js/kitchen-sink.js.txt index 9ecfcce49..bfb11b65a 100644 --- a/test/binaryen.js/kitchen-sink.js.txt +++ b/test/binaryen.js/kitchen-sink.js.txt @@ -5705,3 +5705,4 @@ module loaded from text form: ) ) +sizeof Literal: 24 -- cgit v1.2.3