From aab5f274773f4e1567b02e6950b4d22119cf801d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 17 May 2023 09:10:08 -0700 Subject: EffectAnalyzer: Do not clear break targets before walk()/visit() (#5723) We depend on repeated calls to walk/visit accumulating effects, so this was a bug; if we want to clear stuff then we create a new EffectAnalyzer. Removing that fixes the attached testcase. Also added a unit test. --- test/example/cpp-unit.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'test/example') diff --git a/test/example/cpp-unit.cpp b/test/example/cpp-unit.cpp index d2339f030..e3e1269c3 100644 --- a/test/example/cpp-unit.cpp +++ b/test/example/cpp-unit.cpp @@ -637,6 +637,19 @@ void test_effects() { assert_equal(effects.readsMutableStruct, false); assert_equal(effects.writesStruct, false); } + + { + EffectAnalyzer effects(options, module); + + // If we break, then we transfer control flow. + effects.breakTargets.insert("block"); + assert_equal(effects.transfersControlFlow(), true); + + // Repeated walks accumulate effects, that is, old effects are not + // removed. + effects.walk(&nop); + assert_equal(effects.transfersControlFlow(), true); + } } void test_field() { -- cgit v1.2.3