From a7c66754ba86854ea3e0381986796e6565b93199 Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Tue, 23 Feb 2021 22:46:13 +0000 Subject: Properly use text format type names in printing (#3591) This adds a TypeNames entry to modules, which can store names for types. So far this PR uses that to store type names from text format. Future PRs will add support for field names and for the binary format. (Field names are added to wasm.h here to see if we agree on this direction.) Most of the work here is threading a module through the various functions in Print.cpp. This keeps the module optional, so that we can still print an expression independently of a module, which has always been the case, and which I think we should keep (but, if a module was mandatory perhaps this would be a little simpler, and could be refactored into a form that depends on that). 99% of this diff are test updates, since almost all our tests use the text format, and many of them specify a type name but we used to ignore it. This is a step towards a proper solution for #3589 --- test/lld/hello_world.passive.wat.out | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'test/lld/hello_world.passive.wat.out') diff --git a/test/lld/hello_world.passive.wat.out b/test/lld/hello_world.passive.wat.out index df2e87368..ea7c0e183 100644 --- a/test/lld/hello_world.passive.wat.out +++ b/test/lld/hello_world.passive.wat.out @@ -1,8 +1,8 @@ (module - (type $none_=>_none (func)) - (type $none_=>_i32 (func (result i32))) - (type $i32_=>_i32 (func (param i32) (result i32))) - (type $i32_i32_=>_i32 (func (param i32 i32) (result i32))) + (type $1 (func)) + (type $2 (func (result i32))) + (type $0 (func (param i32) (result i32))) + (type $3 (func (param i32 i32) (result i32))) (import "env" "puts" (func $puts (param i32) (result i32))) (memory $0 2) (data passive "Hello, world\00") -- cgit v1.2.3