From fb7d00b336c8d682cbaaf02c96dab64b39d941ba Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Wed, 20 Dec 2023 14:17:35 -0800 Subject: Drop support for non-standard quoted function names (#6188) We previously supported a non-standard `(func "name" ...` syntax for declaring functions exported with the quoted name. Since that is not part of the standard text format, drop support for it, replacing it with the standard `(func $name (export "name") ...` syntax instead. Also replace our other usage of the quoted form in our text output, which was where we quoted names containing characters that are not allowed to appear in standard names. To handle that case, adjust our output from `"$name"` to `$"name"`, which is the standards-track way of supporting such names. Also fix how we detect non-standard name characters to match the spec. Update the lit test output generation script to account for these changes, including by making the `$` prefix on names mandatory. This causes the script to stop interpreting declarative element segments with the `(elem declare ...` syntax as being named "declare", so prevent our generated output from regressing by counting "declare" as a name in the script. --- test/wasm2js/deterministic.2asm.js.opt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/wasm2js/deterministic.2asm.js.opt') diff --git a/test/wasm2js/deterministic.2asm.js.opt b/test/wasm2js/deterministic.2asm.js.opt index a05554b1a..12ebdd859 100644 --- a/test/wasm2js/deterministic.2asm.js.opt +++ b/test/wasm2js/deterministic.2asm.js.opt @@ -24,7 +24,7 @@ function asmFunc(imports) { var Math_ceil = Math.ceil; var Math_trunc = Math.trunc; var Math_sqrt = Math.sqrt; - function $0() { + function foo() { if (4294967252 / HEAPU32[0] | 0) { wasm2js_trap() } @@ -37,7 +37,7 @@ function asmFunc(imports) { } return { - "foo": $0 + "foo": foo }; } -- cgit v1.2.3