From c25f32dec81d9401efb64cf134aa87991ef21e9d Mon Sep 17 00:00:00 2001
From: Alon Zakai <azakai@google.com>
Date: Fri, 21 Oct 2022 12:15:46 -0700
Subject: [Wasm GC] Externalize/Internalize allow nulls (#5175)

These are encoded as RefAs operations, and we have optimizations that assume those
trap on null, but Externalize/Internalize do not. Skip them there to avoid an error on the
type being incorrect later.
---
 test/lit/passes/optimize-instructions-gc-heap.wast | 54 ++++++++++++++++++++++
 1 file changed, 54 insertions(+)

(limited to 'test')

diff --git a/test/lit/passes/optimize-instructions-gc-heap.wast b/test/lit/passes/optimize-instructions-gc-heap.wast
index e448e57fd..b77678760 100644
--- a/test/lit/passes/optimize-instructions-gc-heap.wast
+++ b/test/lit/passes/optimize-instructions-gc-heap.wast
@@ -766,4 +766,58 @@
   (func $helper-i32 (param $x i32) (result i32)
     (i32.const 42)
   )
+
+  ;; CHECK:      (func $extern.externalize (param $x anyref) (param $y externref)
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (extern.externalize
+  ;; CHECK-NEXT:    (local.get $x)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (extern.externalize
+  ;; CHECK-NEXT:    (ref.as_non_null
+  ;; CHECK-NEXT:     (local.get $x)
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (extern.internalize
+  ;; CHECK-NEXT:    (local.get $y)
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (extern.internalize
+  ;; CHECK-NEXT:    (ref.as_non_null
+  ;; CHECK-NEXT:     (local.get $y)
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT: )
+  (func $extern.externalize (export "ext") (param $x (ref null any)) (param $y (ref null extern))
+    ;; We should not change anything here, and also not hit an internal error.
+    (drop
+      (extern.externalize
+        (local.get $x)
+      )
+    )
+    (drop
+      (extern.externalize
+        (ref.as_non_null
+          (local.get $x)
+        )
+      )
+    )
+    (drop
+      (extern.internalize
+        (local.get $y)
+      )
+    )
+    (drop
+      (extern.internalize
+        (ref.as_non_null
+          (local.get $y)
+        )
+      )
+    )
+  )
 )
-- 
cgit v1.2.3