From d4f8cd5ccabaaf2c55561548d88c075cfa4f765d Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 14 Apr 2021 13:45:28 -0700 Subject: [Wasm GC] Do not inline a function with an RTT parameter (#3808) Inlined parameters become locals, and rtts cannot be handled as locals, unlike non-nullable values which we can at least fix up. So do not inline functions with rtt params. --- test/passes/inlining_all-features.txt | 13 +++++++++++++ test/passes/inlining_all-features.wast | 11 +++++++++++ 2 files changed, 24 insertions(+) (limited to 'test') diff --git a/test/passes/inlining_all-features.txt b/test/passes/inlining_all-features.txt index 8ecf9fa8e..3f9aa57ce 100644 --- a/test/passes/inlining_all-features.txt +++ b/test/passes/inlining_all-features.txt @@ -125,3 +125,16 @@ ) ) ) +(module + (type $struct (struct )) + (type $none_=>_none (func)) + (type $rtt_$struct_=>_none (func (param (rtt $struct)))) + (func $0 (param $rtt (rtt $struct)) + (nop) + ) + (func $1 + (call $0 + (rtt.canon $struct) + ) + ) +) diff --git a/test/passes/inlining_all-features.wast b/test/passes/inlining_all-features.wast index d11353aa4..0aa324e1a 100644 --- a/test/passes/inlining_all-features.wast +++ b/test/passes/inlining_all-features.wast @@ -101,3 +101,14 @@ ) ) ) +;; never inline an rtt parameter, as those cannot be handled as locals +(module + (type $struct (struct)) + (func $0 (param $rtt (rtt $struct)) + ) + (func $1 + (call $0 + (rtt.canon $struct) + ) + ) +) -- cgit v1.2.3