diff options
| author | Noam Postavsky <npostavs@gmail.com> | 2018-08-07 20:40:56 -0400 |
|---|---|---|
| committer | Noam Postavsky <npostavs@gmail.com> | 2018-08-27 19:16:47 -0400 |
| commit | 0250d22eeb8427cb87c58f528f337dc83d0419a5 (patch) | |
| tree | 13185fd4551b6034a1fe3f6f2c10af54b99d6c7f | |
| parent | c8b86362d45a07e0aec0041cade551c3c663ea8c (diff) | |
| download | emacs-0250d22eeb8427cb87c58f528f337dc83d0419a5.tar.gz emacs-0250d22eeb8427cb87c58f528f337dc83d0419a5.tar.bz2 emacs-0250d22eeb8427cb87c58f528f337dc83d0419a5.zip | |
shr: Allow skipping tags with aria-hidden (Bug#32348)
* lisp/net/shr.el (shr-discard-aria-hidden): New option.
(shr-descend): Suppress aria-hidden=true tags if it's set.
* doc/misc/eww.texi (Advanced): Document shr-discard-aria-hidden.
* etc/NEWS: Announce it.
| -rw-r--r-- | doc/misc/eww.texi | 10 | ||||
| -rw-r--r-- | etc/NEWS | 5 | ||||
| -rw-r--r-- | lisp/net/shr.el | 11 |
3 files changed, 25 insertions, 1 deletions
diff --git a/doc/misc/eww.texi b/doc/misc/eww.texi index 43adc2eda0f..aa17eee9d94 100644 --- a/doc/misc/eww.texi +++ b/doc/misc/eww.texi @@ -262,6 +262,16 @@ contrast. If that is still too low for you, you can customize the variables @code{shr-color-visible-distance-min} and @code{shr-color-visible-luminance-min} to get a better contrast. +@vindex shr-discard-aria-hidden +@cindex @code{aria-hidden}, HTML attribute + The HTML attribute @code{aria-hidden} is meant to tell screen +readers to ignore a tag's contents. You can customize the variable +@code{shr-discard-aria-hidden} to tell @code{shr} to ignore such tags. +This can be useful when using a screen reader on the output of +@code{shr} (e.g., on EWW buffer text). It can be useful even when not +using a screen reader, since web authors often put this attribute on +non-essential decorative elements. + @cindex Desktop Support @cindex Saving Sessions In addition to maintaining the history at run-time, EWW will also @@ -405,6 +405,11 @@ and its value has been changed to Duck Duck Go. 'shr-selected-link' face to give the user feedback that the command has been executed. ++++ +*** New option 'shr-discard-aria-hidden'. +If set, shr will not render tags with attribute 'aria-hidden="true"'. +This attribute is meant to tell screen readers to ignore a tag. + ** Htmlfontify *** The functions 'hfy-color', 'hfy-color-vals' and diff --git a/lisp/net/shr.el b/lisp/net/shr.el index edea7cb297c..bc86fe5a383 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -68,6 +68,13 @@ fit these criteria." :group 'shr :type 'boolean) +(defcustom shr-discard-aria-hidden nil + "If non-nil, don't render tags with `aria-hidden=\"true\"'. +This attribute is meant to tell screen readers to ignore a tag." + :version "27.1" + :group 'shr + :type 'boolean) + (defcustom shr-use-colors t "If non-nil, respect color specifications in the HTML." :version "26.1" @@ -509,7 +516,9 @@ size, and full-buffer size." shr-stylesheet)) (setq style nil))) ;; If we have a display:none, then just ignore this part of the DOM. - (unless (equal (cdr (assq 'display shr-stylesheet)) "none") + (unless (or (equal (cdr (assq 'display shr-stylesheet)) "none") + (and shr-discard-aria-hidden + (equal (dom-attr dom 'aria-hidden) "true"))) ;; We don't use shr-indirect-call here, since shr-descend is ;; the central bit of shr.el, and should be as fast as ;; possible. Having one more level of indirection with its |