diff options
| author | Philipp Stephani <phst@google.com> | 2018-06-02 11:59:02 +0200 |
|---|---|---|
| committer | Philipp Stephani <phst@google.com> | 2019-04-19 19:19:35 +0200 |
| commit | 0b4b380ce4989afc59848d2b6a350bd1dd7dc7ca (patch) | |
| tree | d48cd46b86ff19c609dd16f7ef799dd720014ef3 /lisp/emacs-lisp/bytecomp.el | |
| parent | 8aadf6e415b7801cb9fa4c5670b1750da207cf87 (diff) | |
| download | emacs-0b4b380ce4989afc59848d2b6a350bd1dd7dc7ca.tar.gz emacs-0b4b380ce4989afc59848d2b6a350bd1dd7dc7ca.tar.bz2 emacs-0b4b380ce4989afc59848d2b6a350bd1dd7dc7ca.zip | |
Make warning about unescaped character literals more helpful.
See Bug#31676.
* lisp/emacs-lisp/byte-run.el
(byte-run--unescaped-character-literals-warning): New defun.
* src/lread.c (load_warn_unescaped_character_literals): Use new defun.
(syms_of_lread): Define symbol for new defun.
* lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): Use new
defun.
* test/src/lread-tests.el (lread-tests--unescaped-char-literals):
test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-tests--unescaped-char-literals): Adapt unit tests.
Diffstat (limited to 'lisp/emacs-lisp/bytecomp.el')
| -rw-r--r-- | lisp/emacs-lisp/bytecomp.el | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 8bbe6292d9d..4c61e1a4471 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -2082,14 +2082,9 @@ With argument ARG, insert value in current buffer after the form." (not (eobp))) (setq byte-compile-read-position (point) byte-compile-last-position byte-compile-read-position) - (let* ((lread--unescaped-character-literals nil) - (form (read inbuffer))) - (when lread--unescaped-character-literals - (byte-compile-warn - "unescaped character literals %s detected!" - (mapconcat (lambda (char) (format "`?%c'" char)) - (sort lread--unescaped-character-literals #'<) - ", "))) + (let ((form (read inbuffer)) + (warning (byte-run--unescaped-character-literals-warning))) + (when warning (byte-compile-warn "%s" warning)) (byte-compile-toplevel-file-form form))) ;; Compile pending forms at end of file. (byte-compile-flush-pending) |