summaryrefslogtreecommitdiff
path: root/lisp/emacs-lisp/bytecomp.el
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2017-08-26 23:07:01 -0700
committerPaul Eggert <eggert@cs.ucla.edu>2017-08-26 23:07:58 -0700
commit231bfd6818890c0c22181ad253f09c8f2399461d (patch)
tree0b6cdb3591ff182a2ddd31272bc5a3e455d440da /lisp/emacs-lisp/bytecomp.el
parent1be689fbc4df1ca9883f5bdeb5dd3ccc00eae3aa (diff)
downloademacs-231bfd6818890c0c22181ad253f09c8f2399461d.tar.gz
emacs-231bfd6818890c0c22181ad253f09c8f2399461d.tar.bz2
emacs-231bfd6818890c0c22181ad253f09c8f2399461d.zip
Fix over-protection of byte-compiled files
Problem reported by Sven Joachim (Bug#28244). Also, fix similar problem for autoload files. * lisp/emacs-lisp/autoload.el (autoload--save-buffer): Set temp file modes to the buffer-file-name file modes (or 666 if not available) as adjusted by umask. * lisp/emacs-lisp/bytecomp.el (byte-compile-file): Set temp file modes to 666 as adjusted by umask.
Diffstat (limited to 'lisp/emacs-lisp/bytecomp.el')
-rw-r--r--lisp/emacs-lisp/bytecomp.el5
1 files changed, 5 insertions, 0 deletions
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index d769a155aa0..48bbd618712 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1896,10 +1896,15 @@ The value is non-nil if there were no errors, nil if errors."
;; parallel bootstrap), it does not risk getting a
;; half-finished file. (Bug#4196)
(tempfile (make-temp-file target-file))
+ (default-modes (default-file-modes))
+ (temp-modes (logand default-modes #o600))
+ (desired-modes (logand default-modes #o666))
(kill-emacs-hook
(cons (lambda () (ignore-errors
(delete-file tempfile)))
kill-emacs-hook)))
+ (unless (= temp-modes desired-modes)
+ (set-file-modes tempfile desired-modes))
(write-region (point-min) (point-max) tempfile nil 1)
;; This has the intentional side effect that any
;; hard-links to target-file continue to