summaryrefslogtreecommitdiff
path: root/lisp/emacs-lisp/testcover.el
diff options
context:
space:
mode:
authorStefan Monnier <monnier@iro.umontreal.ca>2023-02-18 12:56:24 -0500
committerStefan Monnier <monnier@iro.umontreal.ca>2023-02-18 12:56:24 -0500
commit750bc57cbb8d081566e671e8fc3e27a82588c197 (patch)
treec5b762e170760a1453b2c279663fdadabedc32a7 /lisp/emacs-lisp/testcover.el
parent2ac8d7e64a08ea6e22bb90ad16e2880440fbcf16 (diff)
downloademacs-750bc57cbb8d081566e671e8fc3e27a82588c197.tar.gz
emacs-750bc57cbb8d081566e671e8fc3e27a82588c197.tar.bz2
emacs-750bc57cbb8d081566e671e8fc3e27a82588c197.zip
Don't rely on dynamic scoping to fix bug#59213
Rather than look up a dynamically scoped var to decide whether to trim closures, use an ad-hoc marker on those closures which should not be trimmed. * lisp/emacs-lisp/cconv.el (cconv-dont-trim-unused-variables): Delete var. (cconv-make-interpreted-closure): Use a `:closure-dont-trim-context` markers instead. * lisp/emacs-lisp/edebug.el (edebug-make-enter-wrapper): Use `:closure-dont-trim-context` rather than `cconv-dont-trim-unused-variables`. * lisp/emacs-lisp/testcover.el (testcover-analyze-coverage): Remove workaround for `cconv-dont-trim-unused-variables`. * test/lisp/emacs-lisp/cconv-tests.el (cconv-safe-for-space): New test.
Diffstat (limited to 'lisp/emacs-lisp/testcover.el')
-rw-r--r--lisp/emacs-lisp/testcover.el5
1 files changed, 0 insertions, 5 deletions
diff --git a/lisp/emacs-lisp/testcover.el b/lisp/emacs-lisp/testcover.el
index 1212905f08a..ed31b90ca32 100644
--- a/lisp/emacs-lisp/testcover.el
+++ b/lisp/emacs-lisp/testcover.el
@@ -442,11 +442,6 @@ or return multiple values."
(let ((testcover-vector (get sym 'edebug-coverage)))
(testcover-analyze-coverage-progn body)))
- (`(let ((cconv-dont-trim-unused-variables t))
- (edebug-enter ',sym ,_ (function (lambda nil . ,body))))
- (let ((testcover-vector (get sym 'edebug-coverage)))
- (testcover-analyze-coverage-progn body)))
-
(`(edebug-after ,(and before-form
(or `(edebug-before ,before-id) before-id))
,after-id ,wrapped-form)