diff options
| author | Philipp Stephani <phst@google.com> | 2021-12-13 18:28:13 +0100 |
|---|---|---|
| committer | Philipp Stephani <phst@google.com> | 2021-12-13 18:28:13 +0100 |
| commit | ae169bda2cbec49e30a7ca15828c45f2c638e500 (patch) | |
| tree | d07374fbff216ac169a0c8c199b1166f32ede1da /src/bignum.c | |
| parent | b30b33ed9b3cdacecebef73ad1131f03c635de7a (diff) | |
| download | emacs-ae169bda2cbec49e30a7ca15828c45f2c638e500.tar.gz emacs-ae169bda2cbec49e30a7ca15828c45f2c638e500.tar.bz2 emacs-ae169bda2cbec49e30a7ca15828c45f2c638e500.zip | |
; Add a FIXME regarding the GMP memory allocation functions.
* src/bignum.c (init_bignum): Add a warning about the technically
incorrect use of the GMP memory allocation functions.
Diffstat (limited to 'src/bignum.c')
| -rw-r--r-- | src/bignum.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/bignum.c b/src/bignum.c index 1ac75c19e24..5c587fc6dba 100644 --- a/src/bignum.c +++ b/src/bignum.c @@ -53,6 +53,15 @@ init_bignum (void) { eassert (mp_bits_per_limb == GMP_NUMB_BITS); integer_width = 1 << 16; + + /* FIXME: The Info node `(gmp) Custom Allocation' states: "No error + return is allowed from any of these functions, if they return + then they must have performed the specified operation. [...] + There's currently no defined way for the allocation functions to + recover from an error such as out of memory, they must terminate + program execution. A 'longjmp' or throwing a C++ exception will + have undefined results." But xmalloc and xrealloc do call + 'longjmp'. */ mp_set_memory_functions (xmalloc, xrealloc_for_gmp, xfree_for_gmp); for (int i = 0; i < ARRAYELTS (mpz); i++) |