From e46561a27ef859132775e8025468ad5bf3cbab47 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Thu, 10 Apr 2014 15:15:01 -0400 Subject: Ediff's overlay priorities cause more trouble than they solve. * lisp/vc/ediff-init.el (ediff-shadow-overlay-priority): Remove variable. (ediff-highest-priority): Remove function. * lisp/vc/ediff-util.el (ediff-highlight-diff-in-one-buffer): * lisp/vc/ediff-diff.el (ediff-set-diff-overlays-in-one-buffer) (ediff-set-fine-diff-properties-in-one-buffer): Don't mess with overlay priorities. Fixes: debbugs:17234 --- lisp/vc/ediff-diff.el | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) (limited to 'lisp/vc/ediff-diff.el') diff --git a/lisp/vc/ediff-diff.el b/lisp/vc/ediff-diff.el index 96e8acca294..f429eb35d70 100644 --- a/lisp/vc/ediff-diff.el +++ b/lisp/vc/ediff-diff.el @@ -587,7 +587,6 @@ one optional arguments, diff-number to refine.") (setq pt-saved (ediff-with-current-buffer buff (point))))) (setq overlay (ediff-make-bullet-proof-overlay begin end buff)) - (ediff-overlay-put overlay 'priority ediff-shadow-overlay-priority) (ediff-overlay-put overlay 'ediff-diff-num current-diff) (if (and (ediff-has-face-support-p) ediff-use-faces ediff-highlight-all-diffs) @@ -822,20 +821,9 @@ one optional arguments, diff-number to refine.") 'default (ediff-get-symbol-from-alist buf-type ediff-fine-diff-face-alist) - )) - (priority (if default - 0 - (1+ (or (ediff-overlay-get - (symbol-value - (ediff-get-symbol-from-alist - buf-type - ediff-current-diff-overlay-alist)) - 'priority) - 0))))) - (mapcar (lambda (overl) - (ediff-set-overlay-face overl face) - (ediff-overlay-put overl 'priority priority)) - fine-diff-vector))) + ))) + (dolist (overl fine-diff-vector) + (ediff-set-overlay-face overl face)))) ;; Set overlays over the regions that denote delimiters (defun ediff-set-fine-overlays-for-combined-merge (diff-list reg-num) -- cgit v1.2.3