From a9b884c60f5d17d55e18039b73020a1c726dd048 Mon Sep 17 00:00:00 2001 From: Glenn Morris Date: Tue, 9 Jan 2018 19:59:04 -0800 Subject: Tag some unstable tests, and skip by default (bug#24503) * Makefile.in (check-all): New phony target. * test/Makefile.in (SELECTOR_DEFAULT, SELECTOR_EXPENSIVE): Also skip unstable tests. (SELECTOR_ALL): New variable. (check-all): New phony target. * test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el (eieio-test-method-order-list-6): * test/lisp/emacs-lisp/eieio-tests/eieio-tests.el (eieio-test-37-obsolete-name-in-constructor): Mark as unstable rather than skipping on hydra.nixos.org. --- test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el | 2 +- test/lisp/emacs-lisp/eieio-tests/eieio-tests.el | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'test/lisp/emacs-lisp') diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el index 84661e8770b..c6da9e15fa3 100644 --- a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el +++ b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el @@ -192,7 +192,7 @@ (ert-deftest eieio-test-method-order-list-6 () ;; FIXME repeated intermittent failures on hydra (bug#24503) ;; ((:STATIC C) (:STATIC C-base1) (:STATIC C-base2)) != ((:STATIC C))") - (skip-unless (not (getenv "EMACS_HYDRA_CI"))) + :tags '(:unstable) (let ((eieio-test-method-order-list nil) (ans '( (:STATIC C) diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el index ee739740ae7..5ba094c0072 100644 --- a/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el +++ b/test/lisp/emacs-lisp/eieio-tests/eieio-tests.el @@ -893,8 +893,8 @@ Subclasses to override slot attributes.") (list newname 2)) (ert-deftest eieio-test-37-obsolete-name-in-constructor () - ;; FIXME repeated intermittent failures on hydra (bug#24503) - (skip-unless (not (getenv "EMACS_HYDRA_CI"))) + ;; FIXME repeated intermittent failures on hydra and elsewhere (bug#24503). + :tags '(:unstable) (should (equal (eieio--testing "toto") '("toto" 2)))) (ert-deftest eieio-autoload () -- cgit v1.2.3