From b03338c70d81f2cba9c8a0b4fefbf83ef7a346e0 Mon Sep 17 00:00:00 2001 From: Mattias Engdegård Date: Tue, 19 Sep 2023 15:18:11 +0200 Subject: Warn about duplicated :tag strings in defcustom choices It is bad user experience when two menu items have identical labels. * lisp/emacs-lisp/bytecomp.el (bytecomp--check-cus-type): Add check. * test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-test-defcustom-type): Add test case. --- test/lisp/emacs-lisp/bytecomp-tests.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'test/lisp/emacs-lisp') diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el index a335a7fa1f8..e644417c3d4 100644 --- a/test/lisp/emacs-lisp/bytecomp-tests.el +++ b/test/lisp/emacs-lisp/bytecomp-tests.el @@ -1875,7 +1875,7 @@ EXPECTED-POINT BINDINGS (MODES \\='\\='(ruby-mode js-mode python-mode)) \ (FIXTURE-FN \\='#\\='electric-pair-mode))" fill-column))) (ert-deftest bytecomp-test-defcustom-type () - (cl-flet ((dc (type) `(defcustom mytest nil "doc" :type ',type))) + (cl-flet ((dc (type) `(defcustom mytest nil "doc" :type ',type :group 'test))) (bytecomp--with-warning-test (rx "type should not be quoted") (dc ''integer)) (bytecomp--with-warning-test @@ -1890,6 +1890,9 @@ EXPECTED-POINT BINDINGS (MODES \\='\\='(ruby-mode js-mode python-mode)) \ (bytecomp--with-warning-test (rx "duplicated value in `choice': `a'") (dc '(choice (const a) (const b) (const a)))) + (bytecomp--with-warning-test + (rx "duplicated :tag string in `choice': \"X\"") + (dc '(choice (const :tag "X" a) (const :tag "Y" b) (other :tag "X" c)))) (bytecomp--with-warning-test (rx "`cons' requires 2 type specs, found 1") (dc '(cons :tag "a" integer))) -- cgit v1.2.3