From fffcc7ab25021fd9d73d50cf685a77777d38265c Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Wed, 1 Sep 2021 10:32:49 +0200 Subject: Fix (setf (map-elt map key) (my-func)) * lisp/emacs-lisp/map.el (map-elt): Ensure that the value isn't referenced more than once (bug#50290). --- test/lisp/emacs-lisp/map-tests.el | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'test/lisp/emacs-lisp') diff --git a/test/lisp/emacs-lisp/map-tests.el b/test/lisp/emacs-lisp/map-tests.el index 658ed2e7119..c0f0dbc92be 100644 --- a/test/lisp/emacs-lisp/map-tests.el +++ b/test/lisp/emacs-lisp/map-tests.el @@ -521,5 +521,14 @@ Evaluate BODY for each created map." 'value2)) (should (equal (map-elt ht 'key) 'value2)))) +(ert-deftest test-setf-map-with-function () + (let ((num 0) + (map nil)) + (setf (map-elt map 'foo) + (funcall (lambda () + (cl-incf num)))) + ;; Check that the function is only called once. + (should (= num 1)))) + (provide 'map-tests) ;;; map-tests.el ends here -- cgit v1.2.3