summaryrefslogtreecommitdiff
path: root/src/binary-reader-objdump.cc
Commit message (Collapse)AuthorAgeFilesLines
* Honor -DWERROR=ON for all cmake targets (#1850)Sam Clegg2022-03-071-2/+2
| | | I believe this is why #1849 managed to land without detection.
* Add initial support for code metadata (#1840)Yuri Iozzelli2022-02-251-0/+29
| | | | | | | | | | | | | | | | | | | | | See https://github.com/WebAssembly/tool-conventions/blob/main/CodeMetadata.md for the specification. In particular this pr implements the following: - Parsing code metadata sections in BinaryReader, providing appropriate callbacks that a BinaryReaderDelegate can implement: - BinaryReaderObjdump: show the sections in a human-readable form - BinaryReaderIr: add code metadata in the IR as expressions - Parsing code metadata annotations in text format, adding them in the IR like the BinaryReaderIR does - Writing the code metadata present in the IR in the proper sections when converting IR to binary - Support in wasm-decompiler for showing code metadata as comments in the pseudo-code All the features have corresponding tests. Support for code metadata is gated through the --enable-code-metadata feature. For reading/writing in the text format, --enable-annotations is also required. Missing features: Support for function-level code metadata (offset 0) Extensive validation in validator.cc (like making sure that all metadata instances are at the same code offset of an instruction)
* Use C++17 string_view (#1826)Sam Clegg2022-02-111-136/+144
| | | | | Now that we have C++17 we don't need our own string_view class anymore. Depends on #1825
* wasm-objdump: Print local names during disassembly (#1818)Michael Williamson2022-02-021-0/+42
| | | Fixes #1815
* objdump: Consider params when printing local decl index (#1819)Michael Williamson2022-02-011-1/+10
|
* Fix erroneous reporting of "Data reloctions outside of segments" (#1800)Sam Clegg2022-01-071-2/+8
| | | | | | This check should only not be done during disassembly, only when displaying details. Fixes: #1790
* Clang-format codebase (#1684)Heejin Ahn2021-12-201-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This applies clang-format to the whole codebase. I noticed we have .clang-format in wabt but the codebase is not very well formatted. This kind of mass-formatting PR has fans and skeptics because it can mess with `git blame`, but we did a similar thing in Binaryen a few years ago (WebAssembly/binaryen#2048, which was merged in WebAssembly/binaryen#2059) and it was not very confusing after all. If we are ever going to format the codebase, I think it is easier to do it in a single big PR than dozens of smaller PRs. This is using the existing .clang-format file in this repo, which follows the style of Chromium. If we think this does not suit the current formatting style, we can potentially tweak .clang-format too. For example, I noticed the current codebase puts many `case` statements within a single line when they are short, but the current .clang-format does not allow that. This does not include files in src/prebuilt, because they are generated. This also manually fixes some comment lines, because mechanically applying clang-format to long inline comments can look weird. I also added a clang-format check hook in the Github CI in #1683, which I think can be less controversial, given that it only checks the diff. --- After discussions, we ended up reverting many changes, especially one-liner functions and switch-cases, which are too many to wrap in `// clang-format off` and `// clang-format on`. I also considered fixing `.clang-format` to allow those one-liners but it caused a larger churn in other parts. So currently the codebase does not conform to `.clang-format` 100%, but we decided it's fine.
* Fix type names for function references (#1787)Sam Clegg2021-12-131-13/+13
| | | | | | | | This requires `Type::GetName` to return to be dynamicllay created and return `std::string` rather then a `const char*` As this diff shows this type name is only used in textual output and error messages so should this change should not have a effect of binary parse time or the interpreter.
* wasm-objdump: centralize opcode size calculations. NFC (#1778)Sam Clegg2021-12-081-39/+26
|
* wasm-objdump: Fix disassembly output of selectT instruction (#1777)Sam Clegg2021-12-081-1/+5
| | | | Use `LogOpcodeType` rather than LogOpcodeBare` when the select instruction has a type.
* Show tag names in objdump disassembly (#1774)Sam Clegg2021-12-071-0/+7
| | | | | | | | | Tag names are not officially part of the extended-name-section proposal (because it only deals with naming things that are in the spec already). However, I think its reasonable (and useful) to include these names under a speculative subsection ID, on the basis that tags can only exist when exceptions are enabled and that engines should ignore unknown name types.
* Perform init expression validation outside of the binary reader. NFC (#1770)Sam Clegg2021-12-021-58/+117
| | | | | | | | | | | | | | | | Rather than spocial casing them in the reader we now use the same instruction callbacks for instruction that appear in init expressions as instructions that appear in normal functions. The result of this change is the validation of init expressions is pushed further up the stack. For example, objdump will now quite happily dump modules that use arbitrary instructions in thier init expressions even though they are not valid. To me, this makes sense since objdump does not do instruction validation elsewhere. The change is pre-cursor to allowing a wider variety of instruction to be present in init expressions. See https://github.com/WebAssembly/extended-const
* Refactor init expressions handling in binary-reader-objdump.cc. NFC (#1755)Sam Clegg2021-11-051-35/+42
| | | | This makes thinks a little more precise and is part of paving the way for extended const/init expressions.
* Remove separate OnEndFunc vs OnEndExpr. (#1756)Sam Clegg2021-11-051-6/+0
| | | | We already have EndFunctionBody, and this extra distinction doesn't seem like it is needed.
* Add support for target_features section (#1744)Sam Clegg2021-10-191-1/+8
|
* Support for import/export info in dylink section (#1741)Sam Clegg2021-10-191-0/+30
|
* Fix for wasm-objdump and memory64 segment offsets (#1743)Sam Clegg2021-10-181-8/+10
|
* Support TLS symbol flag (#1706)Sam Clegg2021-09-091-0/+4
| | | See https://reviews.llvm.org/D109426
* Add objdump flag to print section offsets instead of file offsets (#1696)Derek Schuff2021-08-051-3/+11
| | | Currently implemented just for disassembly. It could be added for other sections/functionality in the future.
* [EH] Remove `unwind` (#1682)Heejin Ahn2021-06-291-1/+0
| | | `unwind` was removed. See WebAssembly/exception-handling#156.
* [EH] Replace event with tag (#1678)Heejin Ahn2021-06-221-51/+50
| | | | | | | | | | | We recently decided to change 'event' to 'tag', and 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - https://github.com/WebAssembly/exception-handling/issues/159#issuecomment-857910130 - https://github.com/WebAssembly/exception-handling/pull/161
* objdump: add support for segments flags in the linking section (#1669)Sam Clegg2021-05-131-8/+44
|
* [simd] Implement load lane (#1646)Ng Zhi An2021-03-221-0/+10
| | | | | | | | | This is a new kind of ir/ast node/instruction. It has 3 immediates: memarg align, memarg offset, and lane index. This required new visitor functions in all the places. Drive-by cleanup to share the simd lane parsing logic between shuffle, lane op and this new load lane instructions. This requires rebasing some tests because the error messages are slightly different now.
* objdump: fix typo (#1614)Sam Clegg2021-03-021-1/+1
|
* Update rethrow depth handling and catch_all opcode (#1608)Asumu Takikawa2021-02-181-0/+1
| | | | | | | | | | | | | Give `catch_all` its own opcode: Previously `catch_all` shared an opcode with `else`, but the spec now allocates it the 0x19 opcode. Adjust rethrow depth semantics: Previously this had interpreted the rethrow depth argument as counting only catch blocks, but the spec has clarified that it should count all blocks (in a similar fashion as `br` and related instructions).
* Update exception handling support to current proposal (#1596)Asumu Takikawa2021-02-101-0/+11
| | | | | | | | | | This PR updates the support of exception handling to the latest proposal (that is compatible with future 2-phase exception handling) described in https://github.com/WebAssembly/exception-handling/pull/137 and https://github.com/WebAssembly/exception-handling/pull/143. * Adds back tagged `catch $e`, `catch_all`, and `rethrow N` from a previous version of wabt, but with updates to match the current spec (e.g., `catch_all` shares an opcode with `else`, `rethrow`'s depth indexes only catch blocks, etc). * Adds `unwind` and `delegate` instructions. * Removes `exnref` and `br_on_exn`. * Updates relevant tests. There are some details that could still change (e.g., maybe how `delegate`'s depth is validated), but I'd be happy to submit further PRs if the spec details change.
* objdump: Set table name based on import name (#1599)Sam Clegg2021-01-291-0/+11
|
* wasm-objdump: Report data segment names (#1588)Sam Clegg2020-12-091-2/+19
| | | Also fix ordering of data names and table segment names.
* wasm-objdump: display name of start function (#1581)Sam Clegg2020-12-031-1/+6
|
* Use stderr for all logging and error output (#1579)Sam Clegg2020-12-031-10/+15
| | | | I'm not sure why we were using stdout but the convention is normally to write all logging and error message to stderr.
* wasm-objdump: Honor extended names section (#1573)Sam Clegg2020-11-201-0/+27
| | | This should really have been part of #1554
* Add initial support for extended names sections (#1554)Sam Clegg2020-10-021-0/+12
| | | | | | | | See: https://github.com/WebAssembly/extended-name-section Although this is only a phase 1 proposal its seems pretty straight forward, and is already being implemented in binaryen.
* Add --relocatable support for tables (#1549) (#1549)Andy Wingo2020-10-011-1/+41
| | | | | | | | | | | | | We add relocations for table numbers on each place where we reify a table number (call_indirect, table.get, table.set...), but only if reference types are enabled. Also, fix symbol table generation with unnamed definitions, to allow for relocating references to anonymous functions or tables. As tests, add variants of the relocations and symbol-tables dump tests, with and without all features enabled. Enabling reference types causes relocs to be emitted. We also add --details to the relocations dump tests, so that we can see the target symbols for the relocations.
* Fix integer overflow in objdump name tracking (#1524)Sam Clegg2020-08-191-14/+15
| | | | Fixes: #1520
* Added initial "memory64" proposal support (#1500)Wouter van Oortmerssen2020-08-071-6/+19
|
* Reference types changes to remove subtyping (#1407)Ben Smith2020-05-281-6/+19
| | | | | | | | Main changes: * Rename `anyref` -> `externref` * Remove `nullref` * Rename `hostref` -> `externref` * `ref.null` and `ref.is_null` now have "ref kind" parameter * Add ref kind keywords: `func`, `extern`, `exn`
* Parse ArrayTypes (#1364)Ben Smith2020-03-231-0/+17
| | | | | | | | | | The following formats are supported: * (type (array i32)) * (type (array (field i32))) * (type (array (field (mut i32)))) This PR adds support for reading/writing binary and text, but no interpreter support yet.
* Move more functionality into the v128 type (#1363)Ben Smith2020-03-201-4/+4
| | | | | | | | | * Add lane getters: u{8,16,32,64}, f{32,64}_bits * Add lane setters: set_u{8,16,32,64}, set_f{32,64}_bits * Add set_zero, is_zero * Add To<Type>() and From<Type>() These changes will make it easier to build v128 values in the spectest-interp (which needs to be updated to support SIMD spec tests)
* Add wasm-objdump support for structs (#1361)Ben Smith2020-03-191-0/+21
|
* Initial pass parsing/reading struct (#1352)Ben Smith2020-03-091-10/+10
| | | | | | | | | | | | | | | | | | This parses just the format `(struct)` as a new type. I added a test for this using `wat2wasm`, but that requires a rudimentary binary format. The test runner automatically attempts to rountrip all wat2wasm tests, so this required implementing the wat writing and binary reading too. Here's a summary of the changes: * binary-reader:h: Rename `BinaryReader::OnType` callbacks to `OnFuncType` * binary-reader.h: Add `BinaryReader::OnStructType` * binary-reader.cc: Use a switch after reading the type form to determine whether we're reading a function or struct. * tokens.def: Add new `TokenType::Struct` * lexer-keywords.txt: Add new `struct` keyword * type.h: Add `Type::Struct` type form * wast-parser.cc: Parse `(struct)` in text format * wat-writer.cc: Write Func or Struct type forms
* Convert Type from an enum into a class (#1350)Ben Smith2020-02-281-12/+12
| | | | | | | | | | | | | | | | | This is similar to the way Opcode is structured, which allows us to hang member functions off of the enumeration. The primary motivator for this change is the GC proposal (and the function-references proposal) where a Type can be parameterized: (type $T (struct ...)) (func (local (ref $T) ... ) In this case the type is ref, with a parameter of the type index. Making Type a class will make it easier to store this additional information.
* Update testsuite (w/ reference-types changes) (#1351)Ben Smith2020-02-281-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new table-sub test, checks whether the subtyping is handled properly w/ table.init and table.copy instructions. The BeginElemSegment callback can't pass the element type anymore, since it's not known yet. The callback also can't be deferred, since the BeginElemSegmentInitExpr callback has to happen after the BeginElemSegment callback, but the reference type is not always known until after the initializer expression is read. To work around this, I added a new OnElemSegmentElemType callback. Other element segment changes: * The element type must be tracked in the SharedValidator * A subtle fix: when writing out the segment flags, we need to take into account whether the element type of the segment is not funcref, even if there are no element expressions. In that case, we have to use flag bit 0x4 (SegUseElemExprs). In addition, the TableCopy and TableInit instructions weren't handling table indexes fully. * TableCopy variables are read in the parser (both optional) * TableCopy names are now resolved + applied * TableCopy indexes are now validated * TableInit table variables are read in the parser; this is subtle, since the text format has order $table $segment, but the $table is optional.
* Use standard C++11 on GNU/Clang compilers (#1333)okuoku2020-02-181-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use _POSIX_C_SOURCE where applicable Use _POSIX_C_SOURCE=200809L everywhere except MSVC. For MinGW, it should have same effect in regard of `__USE_MINGW_ANSI_STDIO`. For Cygwin, it will allow to use POSIX APIs under `-std=c++11` environment. * binary-reader-objdump.cc: #include <strings.h> Include `strings.h` because it depends POSIX strcasecmp. * Disable `CMAKE_CXX_EXTENSIONS` explicitly Explicitly disable `CMAKE_CXX_EXTENSIONS` which is ON by default in recent CMake(>= 3.1) which will read implicit `-std=gnu++11` injection. * test-hexfloat: Use <thread> instead of sysconf Use <thread> instead of sysconf which is a bit more "standard" way to do this. * Guard <strings.h> with HAVE_STRCASECMP Guard `strings.h` with `HAVE_STRCASECMP` because non-POSIX platform may not have it.
* Cygwin build fixes (#1332)okuoku2020-02-111-1/+1
| | | | | | | | | | | | | | | * Workaround for Cygwin build On cygwin, `__STRICT_ANSI__` does not show POSIX definitions. Use gnu++11 language instead. * wasm-decompile: Silence -Wsign-compare Silence -Wsign-compare warning, by using unsigned literal one. * wasm-objdump: Fix 4294967296 output on disasm Use `%u` instead of `%lu` as we use `uint32_t` here.
* Support reading from stdin in ReadFile (#1313)Sam Clegg2020-01-231-0/+3
| | | | | | | | This allows tools that read input files to use the special `-` filename to read from stdin. Also, improve the error reported in general in ReadFile. See: #386
* reference-types: Add reference-types spec tests (#1225)Sam Clegg2019-11-251-4/+22
| | | | | | | This change adds most of the tests from the reference-types proposal. There are two tests that require new instructions (`table.fill` and `select_t`) which will be followup changes. See: #1223
* Switch to treating segment flags as a bitfield. NFC (#1232)Sam Clegg2019-11-181-14/+15
| | | | | | | | | | | This is in preparation for updating to latest version reference-types proposal where there is an additional flag and they can be combined. See: https://github.com/WebAssembly/bulk-memory-operations/issues/98 Also, add ERROR_IF to binary-reader.cc as logical corollary to the existing ERROR_UNLESS.
* wasm-objdump: Fix output for passive data elem segments (#1211)Sam Clegg2019-11-071-2/+8
| | | Split out from #1206
* wasm-objdump: Consistent output of table types (#1198)Oliver Horn2019-10-281-4/+5
| | | | | | Adjusts the output of table imports to the output of table declarations and other elements: - `type` instead of `elem_type` - limits: `initial` instead of `init`, check `has_max`
* wasm-objdump: Print `br_table` immediates (#1186)Oliver Horn2019-10-141-2/+8
| | | Print missing `br_table` immediates
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-08 23:52:24 +0000