summaryrefslogtreecommitdiff
path: root/test/spec
Commit message (Collapse)AuthorAgeFilesLines
...
* [simd] Implement load lane (#1646)Ng Zhi An2021-03-222-52/+63
| | | | | | | | | This is a new kind of ir/ast node/instruction. It has 3 immediates: memarg align, memarg offset, and lane index. This required new visitor functions in all the places. Drive-by cleanup to share the simd lane parsing logic between shuffle, lane op and this new load lane instructions. This requires rebasing some tests because the error messages are slightly different now.
* [simd] Implement v128.load{32,64}_zero (#1644)Ng Zhi An2021-03-171-1/+61
| | | | This requires a new ir type, and the relevant implementation of virtual mthods in the various visitors.
* [simd] Implement i64x2.extend_{low,high}_i32x4_{s,u} (#1643)Ng Zhi An2021-03-161-1/+75
| | | Unskip and rebase simd_int_to_int_extend.
* [simd] Implement i64x2 comparisons (#1642)Ng Zhi An2021-03-161-1/+33
| | | Rebase and unskip simd_i64x2_cmp.
* [simd] Implement i32x4.dot_i16x8_s (#1640)Ng Zhi An2021-03-161-1/+12
| | | Rebase and unskip simd_i32x4_dot_i16x8.
* [simd] Implement q15mulrsat_s (#1639)Ng Zhi An2021-03-161-1/+12
| | | Rebase and unskip simd_i16x8_q15mulr_sat_s.
* [simd] Implement extmul instructions (#1638)Ng Zhi An2021-03-125-17/+131
| | | | | | | Renumber floating point rounding instructions since they overlap with these new extmul instructions. Rebase simd_f32x4_rounding and simd_f64x2_rounding. Rebase and unskip simd extmul tests.
* [simd] Implement extadd instructions (#1637)Ng Zhi An2021-03-122-2/+30
| | | | Rebase and unskip simd_i16x8_extadd_pairwise_i8x16.txt and simd_i32x4_extadd_pairwise_i16x8.
* [simd] Implement i64x2.abs (#1636)Ng Zhi An2021-03-121-1/+9
| | | Rebase and unskip simd_i64x2_arith2.txt.
* [simd] Implement i32x4.trunc_sat_f64x2_[su]_zero (#1635)Ng Zhi An2021-03-122-2/+30
| | | | Rebase simd_i32x4_trunc_sat_f64x2.txt and simd_i32x4_trunc_sat_f32x4.txt.
* [simd] Rename widen to extend, implement some double precision ops (#1633)Ng Zhi An2021-03-111-145/+78
| | | | | | | | | | | | 4 double precision conversion instructions are implemented: - f32x4.demote_f64x2_zero - f64x2.demote_low_f32x4 - f64x2.convert_low_i32x4_s - f64x2.convert_low_i32x4_u This is now sufficient to unskip simd_conversions.txt. Rebase a bunch of tests due to the rename from widen to extend.
* Implement i8x16.popcnt and rebase simd_i8x16_arith2.txt (#1625)Ng Zhi An2021-03-111-25/+30
|
* [simd] Rename any_true, implement i64x2 bitmask and all_true (#1624)Ng Zhi An2021-03-043-52/+45
| | | | | | | | | | | * Rename all any_true to v128.any_true * Add i64x2.bitmask and i64x2.all_true, rebase simd_boolean * Unskip spec/simd/simd_i16x8_arith2.txt since i64x2.abs is now implemented * Unskip spec/simd/simd_lane.txt * Update dump interp tests, rebase
* Bump third_party/testsuite to TOT (#1623)Ng Zhi An2021-03-0441-326/+996
| | | | | | | | | | | | | * Bump third_party/testsuite * Run test/update-spec-tests.py * Skip new simd tests that are not implemented * Rebase some tests in test/spec based on latest update to testsuite * Define global_i64 for wasm2c global tests * Skip more simd tests due to updated/new instructions
* Bump testsuite version and fix tests (#1622)Ng Zhi An2021-03-042-57/+69
| | | | | | | | | This is an incremental bump of testsuite, the TOT has SIMD tests which won't work yet. The main fix is for a test added to the spec repo that has an invalid functype in the type section. Based on the spec, the functype should be a single byte 0x60. The leb encoding only comes into effect with the GC proposal.
* Select instr. with multiple results is invalid (#1582)Ben Smith2020-12-031-1/+2
| | | | | | The reference-types proposal adds a select instruction with a type vector, but any number greater than 1 is invalid. Fixes #1577.
* Fix func.wast spec test (#1574)Ben Smith2020-11-231-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix spec test failure in func.wast The wasm text format allows the use of a function type to be specified one of three ways: ``` ;; 1. As an explicit type index or symbol (type 0) ;; 2. As params and results (param i32) (result i64) ;; 3. Both; an explicit type index, params and results (type 0) (param i32) (result i64) ``` Options 2 and 3 are text format sugar, since the binary format always encodes these as an explicit type index. Option 3 needs to check that the type at that index matches the explicitly given params and results. Normally checking whether an index is in bounds is a validation step, not a syntax checking step. However, in this case if the index is out of bounds, then the types cannot be checked, so it must be a syntax error.
* Changes required to make the new Memory64 spec tests run (#1560)Wouter van Oortmerssen2020-10-2610-0/+841
| | | | | These uncovered some things the previous tests didn't! Also required the switching of the location of the index as discussed in https://github.com/WebAssembly/memory64/issues/5 Also one small .py change that ensures the new tests have consistent posix paths.
* Update SIMD support (#1553)Darin Morrison2020-10-2615-850/+1210
| | | | | | | | | | | | | * Update testsuite * Update test results * Disallow lane nums with optional + for simd ops * Update simd support * Mark `test/spec/func.txt` as failing Co-authored-by: Darin Morrison <darinmorrison@users.noreply.github.com>
* Update testsuite to 646b43e (#1555)Wouter van Oortmerssen2020-09-3016-2340/+118
| | | (this is HEAD~1 as of this writing, HEAD containing the Memory64 tests which I want to land separately)
* Added initial "memory64" proposal support (#1500)Wouter van Oortmerssen2020-08-071-8/+4
|
* Update testsuite; fix conversion errors (#1502)Ben Smith2020-07-292-103/+103
| | | | | | | | | | | | The interpreter and wasm2c were incorrectly handling some float-to-int conversions. For clarity, the wasm2c implementations of these conversions now matches the implementation in interp-math.h more closely (e.g. the numeric ranges are written as `x >= min && x <= max` in both cases). Quite a few wasm2c tests were previously being skipped, since wasm2c doesn't currently support multi-value; it's better instead to duplicate the tests here and disable the parts that are not supported so we don't lose test coverage.
* Remove ref.is_null type parameter (#1474)Ben Smith2020-07-155-39/+39
| | | | | | | | | See https://github.com/WebAssembly/reference-types/issues/99. This change also updates the testsuite, so the spec tests pass too. In addition, the behavior of `br_table` is no longer different from MVP, and has a text to confirm this. That is now fixed in `type-checker.cc` too.
* Revert br_table in reference types proposal (#1484)Ben Smith2020-07-152-2/+2
| | | | | | The reference types proposal originally modified the `br_table` behavior to only check arity, not the specific types. This was to remove a subtyping check, but now that subtyping has been removed, we can revert back to the original (MVP) br_table behavior.
* [wasm2wat] Write select type immediate (#1451)Ben Smith2020-05-291-1/+2
| | | | | | | | | | | | | | | The main fix is in `wat-writer.cc`, where the type immediate was never being printed. But I've also included a change to how `select` type immediates are represented in wabt. Previously, a bare `select` instruction would be stored with the type `Type::Any`. This is not a real wasm type, and is primarily used for type validation. The spec instead considers this form of `select` to have an empty type immediate, which is closer to the `Type::Void` type. This commit now uses `Type::Void` (or an empty `TypeVector`) to represent the bare `select` instruction. Fixes #1444.
* Reference types changes to remove subtyping (#1407)Ben Smith2020-05-2833-2109/+2435
| | | | | | | | Main changes: * Rename `anyref` -> `externref` * Remove `nullref` * Rename `hostref` -> `externref` * `ref.null` and `ref.is_null` now have "ref kind" parameter * Add ref kind keywords: `func`, `extern`, `exn`
* Update testsuite (#1424)Ben Smith2020-05-1314-649/+1174
| | | | | | | Includes the three merged proposals (nontrapping-float-to-int, sign-extension, multi-value). It also has one bug fix when parsing table limits (when the min or max size does not fit in a 32-bit int).
* Enabled merged proposals by default (#1405)Alex Crichton2020-05-0619-18/+9
| | | | | | | | | | | | | This enables three proposals by default since they've been merged into the upstream specification: * `saturating-float-to-int` - WebAssembly/spec#1143 * `sign-extension` - WebAssembly/spec#1144 * `multi-value` - WebAssembly/spec#1145 Most of the fallout from this is in the test suite with lots of `--enable` flags getting removed and some tests which now unconditionally pass also getting removed. Two spec tests explicitly pass `--disable` until the spec test submodule is updated.
* Renumber SIMD opcodes (#1403)Deepti Gandluri2020-05-0414-114/+115
| | | | | | | * Fix typo in I8X16AvgrU * Update tests * Skip simd_const test till it is updated
* Update testsuite (#1381)Ben Smith2020-03-279-115/+263
| | | | * Add i{8x16,16x8,32x4}.abs instructions * Implement IntAbs in interp-math.h
* Update testsuite (for SIMD) (#1373)Ben Smith2020-03-2531-0/+5011
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lots of changes necessary to make this work, as well as some bug fixes. The main change is allowing `nan:canonical` and `nan:arithmetic` as a possible value for each lane of a `v128`. This needs to propogate through the parser, IR, the JSON format, and the spec interpreter. This also changes the format of the spec JSON file, where a SIMD value is now stored as a list of values instead of a single u128: ``` {"type": "v128", "lane_type": "i32", "value": ["0", "0", "0", "0"]} ``` Since the lane type can be `i8` and `i16`, these types can now be used in more places (not just the decompiler). They'll be used for the GC proposal too (for packed values), so I've updated them to use the binary value specified for that proposal. Here are the actual SIMD fixes: * SIMD lanes are malformed if they don't match the binary format, but invalid if they are smaller than the lane width. For example, `i8x16.extract_lane_s` is malformed if the lane is >= 256, because the lane is stored as a byte. But it is invalid if the lane is >= 16. * The `i8x16.narrow_i16x8_u`, `i16x8.narrow_i32x4_u` and `i64x2.load_32x2_u` instructions were not handling sign-extension propoerly. TODO: This code is pretty clumsy now; it would be better to have a universal `Value` and `ExpectedValue` that can be used everywhere, so the logic doesn't need to be duplicated.
* Always generate DataCount section, even if number of datas is 0 (#1369)Rian Hunter2020-03-232-4/+10
| | | | | | | | | | | | * Always generate DataCount section, even if number of datas is 0 The bulk-memory spec requires that a DataCount section is always present if a memory.init or data.drop instruction is present in the following code section. This requirement remains even if the number of datas is 0, so remove that condition. Fixes #1368 * Fix tests
* Remove validation from the BinaryReader (#1354)Ben Smith2020-03-1129-70/+138
| | | | | | | Validation should only happen in ValidateModule, BinaryReader should only check whether the binary is malformed. This change also fixes a few places in BinaryReaderIR where an index is assumed to be valid.
* Fix TODOs in validator; only affects error outputBen Smith2020-02-2917-33/+33
| | | | | | The major change to the error output is showing the max value instead of max value - 1. It's a bit weird to see "out of range: 0 (max 0)" but seeing 4294967295 is strictly worse.
* Update testsuite (w/ reference-types changes) (#1351)Ben Smith2020-02-283-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new table-sub test, checks whether the subtyping is handled properly w/ table.init and table.copy instructions. The BeginElemSegment callback can't pass the element type anymore, since it's not known yet. The callback also can't be deferred, since the BeginElemSegmentInitExpr callback has to happen after the BeginElemSegment callback, but the reference type is not always known until after the initializer expression is read. To work around this, I added a new OnElemSegmentElemType callback. Other element segment changes: * The element type must be tracked in the SharedValidator * A subtle fix: when writing out the segment flags, we need to take into account whether the element type of the segment is not funcref, even if there are no element expressions. In that case, we have to use flag bit 0x4 (SegUseElemExprs). In addition, the TableCopy and TableInit instructions weren't handling table indexes fully. * TableCopy variables are read in the parser (both optional) * TableCopy names are now resolved + applied * TableCopy indexes are now validated * TableInit table variables are read in the parser; this is subtle, since the text format has order $table $segment, but the $table is optional.
* Always check index before accessing vectors (#1347)Ben Smith2020-02-282-2/+2
| | | | | | | | Since the validator tries to print as many errors as possible, it shouldn't stop when the index is invalid (since this may produce future errors). Instead it uses a default value. This is encoded in a new function called CheckIndexWithValue, which either accesses the vector, or uses a default value.
* Share validator between IR + binary-reader-interp (#1346)Ben Smith2020-02-2719-68/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | The TypeChecker was already shared, but the rest of the other validation logic was duplicated. This change creates a SharedValidator which is used by both the Validator and the BinaryReaderInterp classes. The validator is structured similarly to TypeChecker as a collection of functions. It's assumed that the functions will be called in the same order as sections occur in the binary format. The IR valiator does this too, even though it's possible to validate components out-of-order in that case. This change also splits Module validation and Script validation into two different classes. It should have been written this way in the first place, and it's nice to do as part of this change since the module validator logic is mostly moved into the SharedValidator anyway. Next steps: * Remove all validation from BinaryReader and move it into the SharedValidator. * Move the TypeChecker into the SharedValidator (maybe not necessary) * Ensure that validation occurs before creating IR from binary (use SharedValidator in BinaryReaderIR? or maybe create BinaryReaderValidator passthru that both BinaryReaderIR and BinaryReaderInterp use?) * Rename Validator -> IRValidator, SharedValidator -> Validator
* New interpreter (#1330)Ben Smith2020-02-2115-313/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's modeled closely on the wasm-c-api. All runtime objects are garbage-collected. The GC'd objects are subclasses of `Object` and all stored in the `Store`. GC roots can be created using a RefPtr<T> struct. The `Module` stores no runtime objects, only description structs (named `*Desc`, e.g. `FuncDesc`). Instantiation takes these descriptors and turns them into runtime objects (e.g. `FuncDesc` is used to create a `Func`). Only import-matching occurs during instantiation; all other validation is assumed to have occurred during Module compilation. As with the previous interpreter, the wasm instructions are not executed directly, and instead compiled to an instruction stream that is easier to interpret (e.g. all branches become gotos). It's still a stack machine, though. The previous interpreter would always compile and instantiate in one step, which means that it was always known whether an imported function is a host function or wasm function. As a result, calls between modules that stayed in wasm could be very cheap (just update PC). Now that the module is compiled before instantiation, an imported function call always has to check first, which may be a slight performance hit. One major difference to the structure of the interpreter is that floating-point values are passed directly, instead of using their equivalent bit pattern. This is more convenient in general, but requires annotating all functions with WABT_VECTORCALL so Visual Studio x86 works properly (otherwise floats are passed in the x87 FP stack). Instruction stream decoding/tracing/disassembling is now all handled in the `Istream` class. This reduces a lot of duplication between the three, which makes the logging-all-opcodes and tracing-all-opcodes less valuable, so I've removed them. Here are the changes to files: binary-reader-metadata.{h,cc} -> [removed] interp-{disassemble.trace}.cc -> istream.{h,cc} There are new helper files: interp-util.{h,cc}: Primarily print debugging functions interp-math.h: Templates used for handling wasm math
* Fix memory/table check to include imported+defined (#1336)Ben Smith2020-02-194-6/+5
|
* Update testsuite (#1327)Sam Clegg2020-02-057-58/+404
| | | | | The main change here is the addition of declared elem sections.
* Omit the DataCount section unless it is required (#1312)Ben Smith2020-01-2120-607/+603
| | | | | | | | | | | | | See #1189 and #1311. Even if bulk memory is enabled, it can be convenient to omit the DataCount section for MVP compatibility. This change only includes the DataCount section when an instruction requires it; either `data.drop` or `memory.init`. It is also omitted if there are no data segments. Rather than doing a second pass on the instructions, this implementation unconditionally writes the DataCount section, but removes it when it is not needed. This required adding a function to truncate a stream (Stream::Truncate).
* Update testsuite (#1308)Ben Smith2020-01-1624-395/+2637
| | | | | | | | | | * Remove `assert_return_func`. This is now handled by using `assert_return` with `(ref.func)`. * The reference types proposal depends on the bulk memory proposal, so using `--enable-reference-types` automatically includes `--enable-bulk-memory`. * `table.fill` no longer clamps to the valid range, and instead checks before writing anything. This matches the other bulk instructions.
* Error on memory.init|data.drop without DataCount (#1297)Ben Smith2020-01-101-4/+2
| | | | | | See #1176. This was working in the spec interpreter because of the way the segment indexes are handled, but it's better to handle it earlier in the binary reader.
* Update testsuite (#1275)Sam Clegg2020-01-0910-611/+616
| | | | | | | | | | | | | | | | | The two primary changes involved are: 1. Removal of `assert_return_canonical_nan`/`arithetic nan` in favor of special `nan:canonical`/`nan:arithmetic` constants that can only be used in test expectations. See: https://github.com/WebAssembly/spec/pull/1104 2. New trapping behaviour for bulk memory operations. Range checks are now performed up front for opterations such as memory.fill and memory.copy. See: https://github.com/webassembly/bulk-memory-operations/issues/111 And: https://github.com/webassembly/bulk-memory-operations/pull/123 The old behaviour is still kept around to support table.fill which is defined in reference-types proposal and has yet to be updated.
* Segment flags should be MVP-compat when possible (#1286)Ben Smith2020-01-081-63/+63
| | | | This should fix #1280, #1268, #1269.
* Several fixes for reference types (#1278)Heejin Ahn2020-01-081-1/+1
| | | | | | | - Allow `ref.func` for global initialization expressions - Allow `nullref` as a full-fledged type, after WebAssembly/reference-types#66 - Enable reference types when exnref is used (The reference types proposal is a prerequisite of the EH proposal)
* reference-types: add final test: br_table (#1264)Sam Clegg2019-12-132-1/+73
| | | | | | | | | | | | | | This requires some slightly different validation rules for MVP vs interface-types. There is a test in unreachable-invalid.wast that was removed in the reference-types repo: type-br_table-label-num-vs-label-num-after-unreachable This test depends on the old validation rules and still exists in the master testsuite so we need to continue to support both sets of rules for now.
* Run update-spec-tests.py and add resulting missing tests (#1263)Sam Clegg2019-12-125-0/+575
| | | | This found one bug in the parsing of active elem segments with uncref style elements.
* Add one more test from reference-types: unreached-invalid (#1262)Sam Clegg2019-12-121-0/+337
|
* reference-types: add support for typed select (#1253)Sam Clegg2019-11-261-0/+70
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-05 03:36:27 +0000