From 38a76ebf4108f3044139b6662666575b1117a07c Mon Sep 17 00:00:00 2001 From: Keith Winstein Date: Fri, 27 Jan 2023 16:14:19 -0800 Subject: Make wasm2c output UBSAN-clean (and run w2c CI w/ UBSAN) (#2080) We had been running the GitHub UBSAN wasm2c tests with -fsanitize=undefined but without -fno-sanitize-recover, meaning some of the spec tests were printing UBSAN error messages but still returning 0, so we weren't seeing the test failures. --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 684f589b..3067c173 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -105,7 +105,7 @@ jobs: env: USE_NINJA: "1" CC: "clang" # used by the wasm2c tests - WASM2C_CFLAGS: "-fsanitize=undefined" + WASM2C_CFLAGS: "-fno-sanitize-recover=undefined" steps: - uses: actions/setup-python@v1 with: -- cgit v1.2.3