From a7d484ef3d1f64649dd9f48cb1d5434f0fda561b Mon Sep 17 00:00:00 2001 From: Keith Winstein Date: Mon, 11 Jul 2022 17:12:49 -0700 Subject: wasm2c: run tests with -O2 on non-Windows (#1939) Enable optimization when compiling the wasm2c output on non-Windows platforms (effectively GCC and clang). This required: - Preventing load instructions from being optimized away if their value is unused (using inline assembly with an input operand and empty code). This is necessary to force an OOB trap on platforms that use mprotect and the signal handler to detect OOB. - Disabling tail-call optimization in the compiler, to make sure that infinite recursion traps. (This required bumping the version of macOS in GitHub Actions to get a new-enough AppleClang. We should revert this back to 'macos-latest' as soon as that becomes the default.) - Using NaN-quieting versions of a bunch of FP ops that were previously only used on Windows, and adding floor/ceil and promotion/demotion. - Using the '-frounding-math' and '-fsignaling-nans' compiler flags to tell GCC and clang not to fold certain FP ops (e.g. subtracting zero, multiplying by 1). Fixes #1925. --- .github/workflows/build.yml | 4 ++-- .github/workflows/build_release.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to '.github') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 18f923e6..98793089 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,7 +30,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-12, windows-latest] steps: - uses: actions/setup-python@v1 with: @@ -43,7 +43,7 @@ jobs: if: matrix.os == 'ubuntu-latest' - name: install ninja (osx) run: brew install ninja - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-12' - name: install ninja (win) run: choco install ninja if: matrix.os == 'windows-latest' diff --git a/.github/workflows/build_release.yml b/.github/workflows/build_release.yml index 1c75638e..285423fb 100644 --- a/.github/workflows/build_release.yml +++ b/.github/workflows/build_release.yml @@ -15,7 +15,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-12, windows-latest] defaults: run: shell: bash @@ -33,7 +33,7 @@ jobs: - name: install ninja (osx) run: brew install ninja - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-12' - name: install ninja (win) run: choco install ninja -- cgit v1.2.3